chore(ci): replace fragile grep/awk version extraction with yq#14860
Open
chore(ci): replace fragile grep/awk version extraction with yq#14860
Conversation
Co-Authored-By: Timothy Gragg <pipergragg@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace a fragile
grep/awkpattern for extracting the CLI version fromversions.ymlwith a proper YAML query usingyq(pre-installed onubuntu-latest).Changes Made
bulk-update-clijob, replaced:version=$(head -n 20 packages/cli/cli/versions.yml | grep -m 1 "version:" | awk '{print $3}')version=$(yq '.[0].version' packages/cli/cli/versions.yml)Why: The old
grep "version:"pattern also matchesirVersion:lines (since"version:"is a substring). Whilegrep -m 1currently picks up the correct line becauseversion:appears beforeirVersion:in each entry, this is order-dependent and fragile. Usingyqproperly parses the YAML and directly reads.[0].version.Review Checklist
yqis pre-installed onubuntu-latestrunners (it is).[0].versionmatches the array-of-objects structure inpackages/cli/cli/versions.ymlTesting
grep/awkpatternLink to Devin session: https://app.devin.ai/sessions/7de29af33dd94752b8267744bbe3e89b
Requested by: @pgragg