fix(updater): address review feedback and CI timeout on #737

Add QtQuick.Layouts import for the toast, reset Idle state after silent
check failures, clear m_silentCheck on early returns, filter telemetry
payloads in UpdaterTelemetry, and skip check.success on invalid compare.
Limit build-wrapper to test targets and raise unit-tests-linux cap to 90m.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: fernandotonon

.github/workflows/deploy.yml

@@ -895,9 +895,9 @@ jobs:
     needs: [build-n-cache-assimp-linux, build-n-cache-ogre-linux]
     runs-on: ubuntu-latest
     # Hard cap on the whole job. The full sweep takes ~12 min normally
-    # (build + xvfb + ~25 suites + coverage + sonar). Cap at 60 so a
+    # (build + xvfb + ~25 suites + coverage + sonar). Cap at 90 so a
     # cold ccache build on a large PR still finishes under the limit.
-    timeout-minutes: 60
+    timeout-minutes: 90
     permissions: read-all
     env: 
           LD_LIBRARY_PATH: gcc_64/lib/:/usr/local/lib/:/usr/local/lib/OGRE/:/usr/local/lib/pkgconfig/:/lib/x86_64-linux-gnu/
@@ -1043,8 +1043,21 @@ jobs:
           # (ccache wraps the compiler, so build-wrapper's intercept is
           # transparent to the cache layer).
 
-          # Run build-wrapper to capture compilation into a named directory
-          build-wrapper-linux-x86-64 --out-dir build-wrapper-output make -C build -j$(nproc)
+          # Build only test targets (BUILD_QT_MESH_EDITOR=OFF) so the compile
+          # phase leaves room for the ~25-suite test sweep within the job cap.
+          build-wrapper-linux-x86-64 --out-dir build-wrapper-output \
+            make -C build -j$(nproc) \
+              UnitTests \
+              qtmesh_test_common \
+              qtmesh_updater \
+              qtmesh_ps1core_stub \
+              qtmesh_ps1core_libretro \
+              MaterialEditorQML_test \
+              MaterialEditorQML_qml_test \
+              MaterialEditorQML_perf_test \
+              CloudAccountMenuButton_test \
+              ProjectPackager_test \
+              MaterialEditorQML_qml_test_runner
 
           echo "=== ccache statistics ==="
           ccache -s || true

qml/UpdateToast.qml

@@ -1,5 +1,6 @@
 import QtQuick
 import QtQuick.Controls
+import QtQuick.Layouts
 import QtQuick.Window
 import PropertiesPanel 1.0
 
@@ -15,8 +16,6 @@ Window {
 
     property string versionText: ""
 
-    signal viewUpdateClicked()
-
     function showForVersion(version) {
         versionText = version
         reposition()

src/main.cpp

@@ -32,6 +32,7 @@
 #include "AppLaunchHandler.h"
 #ifdef ENABLE_AUTO_UPDATER
 #include "updater/UpdaterController.h"
+#include "updater/UpdaterTelemetry.h"
 #endif
 
 #ifndef Q_OS_WIN
@@ -190,6 +191,8 @@ int main(int argc, char *argv[])
     for (int i = 1; i < argc; ++i) {
         if (QString::fromUtf8(argv[i]) == QLatin1String("--no-update-check")) {
             UpdaterController::setSessionBackgroundChecksDisabled(true);
+            UpdaterTelemetry::breadcrumb(QStringLiteral("updater.background.skip"),
+                                         QStringLiteral("session_disabled"));
         }
     }
 #endif

src/mainwindow.cpp

@@ -30,6 +30,7 @@
 #include "SentryReporter.h"
 #ifdef ENABLE_AUTO_UPDATER
 #include "updater/UpdaterController.h"
+#include "updater/UpdaterTelemetry.h"
 #endif
 #include <QDialog>
 #include <QProgressDialog>
@@ -4523,6 +4524,9 @@ void MainWindow::showUpdaterDialog(bool runCheck)
 
 void MainWindow::showUpdateToast(const QString& version)
 {
+    UpdaterTelemetry::breadcrumb(QStringLiteral("updater.background.toast"),
+                                 QStringLiteral("version=%1").arg(version));
+
     if (m_updateToastEngine) {
         if (auto* toast = m_updateToastWindow) {
             QMetaObject::invokeMethod(toast, "showForVersion", Q_ARG(QVariant, version));

src/updater/UpdaterController.cpp

@@ -99,6 +99,7 @@ UpdaterController::UpdaterController(QObject* parent)
 
                 if (!networkError.isEmpty()) {
                     if (wasSilent) {
+                        setState(State::Idle);
                         UpdaterTelemetry::breadcrumb(
                             QStringLiteral("updater.background.error"),
                             QStringLiteral("network_error"),
@@ -120,6 +121,7 @@ UpdaterController::UpdaterController(QObject* parent)
 
                 if (!result.parseOk) {
                     if (wasSilent) {
+                        setState(State::Idle);
                         UpdaterTelemetry::breadcrumb(
                             QStringLiteral("updater.background.error"),
                             QStringLiteral("parse_error"),
@@ -140,11 +142,13 @@ UpdaterController::UpdaterController(QObject* parent)
                 }
 
                 applyCheckResult(result);
-                UpdaterTelemetry::breadcrumb(
-                    QStringLiteral("updater.check.success"),
-                    QStringLiteral("remote=%1 comparison=%2")
-                        .arg(result.release.tagName)
-                        .arg(static_cast<int>(result.comparison)));
+                if (result.comparison != UpdateVersion::Comparison::Invalid) {
+                    UpdaterTelemetry::breadcrumb(
+                        QStringLiteral("updater.check.success"),
+                        QStringLiteral("remote=%1 comparison=%2")
+                            .arg(result.release.tagName)
+                            .arg(static_cast<int>(result.comparison)));
+                }
                 logDialogStateBreadcrumb();
                 finishSilentCheck();
             });
@@ -470,6 +474,8 @@ void UpdaterController::checkForUpdates()
         if (!m_silentCheck) {
             setState(State::PackageManaged);
             logDialogStateBreadcrumb();
+        } else {
+            finishSilentCheck();
         }
         return;
     }
@@ -478,11 +484,16 @@ void UpdaterController::checkForUpdates()
         if (!m_silentCheck) {
             setState(State::UnknownInstall);
             logDialogStateBreadcrumb();
+        } else {
+            finishSilentCheck();
         }
         return;
     }
 
     if (m_state == State::Checking) {
+        if (m_silentCheck) {
+            finishSilentCheck();
+        }
         return;
     }
 

src/updater/UpdaterTelemetry.cpp

@@ -7,7 +7,7 @@ namespace UpdaterTelemetry {
 
 void breadcrumb(const QString& category, const QString& message, const QString& level)
 {
-    if (!SentryReporter::isEnabled()) {
+    if (!SentryReporter::isEnabled() || !isAllowedTelemetryMessage(message)) {
         return;
     }
     SentryReporter::addBreadcrumb(category, message, level);

src/updater/UpdaterTelemetry_test.cpp

@@ -33,3 +33,13 @@ TEST(UpdaterTelemetryTest, BreadcrumbHonorsTelemetryOptOut)
                                  QStringLiteral("channel=stable local=3.5.3"));
     SentryReporter::setEnabled(previous);
 }
+
+TEST(UpdaterTelemetryTest, BreadcrumbDropsDisallowedPayloads)
+{
+    const bool previous = SentryReporter::isEnabled();
+    SentryReporter::setEnabled(true);
+    // Must not crash; disallowed payloads are silently dropped.
+    UpdaterTelemetry::breadcrumb(QStringLiteral("updater.download.complete"),
+                                 QStringLiteral("file=/tmp/foo.zip"));
+    SentryReporter::setEnabled(previous);
+}