fix(import): restore textured viewport and paint preview on File→Open#757
Conversation
Rebind RTSS materials for newly imported entities (same path cloud downloads already used) and load texture-paint buffers from embedded/disk sources before GPU readback, which fails for many imported FBX textures on Linux. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
More reviews will be available in 58 minutes and 28 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbf62a7e71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| MeshImporterExporter::rebindEntityMaterials(static_cast<Ogre::Entity*>(obj), | ||
| textureSearchRoots); |
There was a problem hiding this comment.
When File→Open imports multiple meshes from different directories, this passes one merged textureSearchRoots list to every new entity. hydrateEntityTexturesFromSearchPaths() keys sidecar files by basename/relative path and keeps the first match it sees, so two assets that both reference common names like diffuse.png will cause later entities to be rebound using the first asset's texture instead of their own. Please scope the roots to the entity's source file (or otherwise preserve a per-import mapping) before rebinding.
Useful? React with 👍 / 👎.
Use each mesh's qtme.source_path binding for sidecar texture lookup so multi-file File→Open imports cannot cross-bind common texture basenames. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed Codex P2 feedback in b2fd106: texture rebind now uses each entity's |
|
Merged latest |
Sync README and website pinned refs via sync-doc-versions-from-cmake.sh. Co-authored-by: Cursor <cursoragent@cursor.com>
|
1 participant
Summary
importMeshs), matching the post-import path cloud downloads already used — fixes white/untextured models in the 3D viewport on Linux.textureSearchRootsForImportFile()so cloud and local imports share the same sidecar texture search roots.Scope
This PR intentionally does not include UV Editor work (epic #458). UV editor will be restarted slice-by-slice in follow-up PRs.
Test plan
QtMeshEditortarget)Made with Cursor