feat(lights): complete Slice I extras — groups, solo, IES, area lights (#491)#842
Conversation
Adds user light collections, per-viewport solo visibility, LM-63 IES profile import with gizmo polar plot, and optional area-light proxies for #491. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (28)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolve CMakeLists.txt conflict: keep 3.20.0 base and retain ENABLE_AREA_LIGHTS from Slice I. Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7be828f5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Save pre-solo visibility instead of re-reading fromHandle during render pass; persist user enabled in light_user_enabled binding for area lights; apply IES power from snapshot base (idempotent); index candela horizontal-major. Co-authored-by: Cursor <cursoragent@cursor.com>
|
1 participant
Summary
groupKind: "collection")ENABLE_AREA_LIGHTS, default ON) using multi-point proxy lights + gizmosCloses remaining #491 acceptance criteria after light linking (#828).
Test plan
UnitTests --gtest_filter="IesProfileTest.*:LightGroupLibraryOgreTest.*:LightLinkingOgreTest.*"(11/11 pass on Linux/Xvfb)QtMeshEditorbuilds on Linux.ieson spotlight; confirm cone + gizmo polar plotMade with Cursor