Skip to content

Landing page makeover#1131

Open
RemDelaporteMathurin wants to merge 22 commits intomainfrom
update-homepage
Open

Landing page makeover#1131
RemDelaporteMathurin wants to merge 22 commits intomainfrom
update-homepage

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Apr 29, 2026

Description

Summary

Related Issues

Motivation and Context

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔨 Code refactoring (no functional changes, no API changes)
  • 📝 Documentation update
  • ✅ Test update (adding missing tests or correcting existing tests)
  • 🔧 Build/CI configuration change

Testing

  • All existing tests pass locally (pytest)
  • I have added new tests that prove my fix is effective or that my feature works

Code Quality Checklist

  • My code follows the code style of this project (Ruff formatted: ruff format .)
  • My code passes linting checks (ruff check .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Documentation

  • I have updated the documentation accordingly (if applicable)
  • I have added docstrings to new functions/classes following the project conventions

Breaking Changes

Screenshots/Examples

Additional Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.10%. Comparing base (35b86fe) to head (5a1e04a).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   94.90%   95.10%   +0.20%     
==========================================
  Files          44       44              
  Lines        3376     3619     +243     
==========================================
+ Hits         3204     3442     +238     
- Misses        172      177       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KulaginVladimir
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin, Looks awesome!

Some optional suggestions:

  1. In the carousel with FESTIM examples, Permeation through a multi-layer membrane does not look as visually impressive or as easy to understand as, for example, the monoblock simulations. The Tritium permeator probe example also seems a bit overcomplicated, with many small subfigures. The image could perhaps be simplified for the gallery.
  2. I think the icons are too small. For example, the Python icon is barely distinguishable, although their size of course depends on whether they need to fit in a single row.
  3. In dark mode, the text in the panels lacks contrast with the background, but it looks fine on hover.
image

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator Author

@RemDelaporteMathurin, Looks awesome!

Some optional suggestions:

  1. In the carousel with FESTIM examples, Permeation through a multi-layer membrane does not look as visually impressive or as easy to understand as, for example, the monoblock simulations. The Tritium permeator probe example also seems a bit overcomplicated, with many small subfigures. The image could perhaps be simplified for the gallery.
  2. I think the icons are too small. For example, the Python icon is barely distinguishable, although their size of course depends on whether they need to fit in a single row.
  3. In dark mode, the text in the panels lacks contrast with the background, but it looks fine on hover.
image

Thanks @KulaginVladimir I've updated the page based on your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants