Skip to content

Point data vs cell data#33

Open
jhdark wants to merge 3 commits intomainfrom
point-data-vs-cell-data
Open

Point data vs cell data#33
jhdark wants to merge 3 commits intomainfrom
point-data-vs-cell-data

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Apr 6, 2026

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to foam2dolfinx?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.60%. Comparing base (9134427) to head (5d87990).

Files with missing lines Patch % Lines
src/foam2dolfinx/open_foam_reader.py 20.00% 12 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9134427) and HEAD (5d87990). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (9134427) HEAD (5d87990)
5 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   97.22%   87.60%   -9.62%     
==========================================
  Files           2        2              
  Lines         108      121      +13     
==========================================
+ Hits          105      106       +1     
- Misses          3       15      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant