You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
STAFF ENGINEER REVIEW: CHANGES REQUESTED — mark_user_blocked now preserves user.type for normal users and only writes blocked_bot_at, but src/flows/monitors/ghost_users.py still excludes blocked users only via u.type NOT IN ('blocked_bot', 'banned', 'waitlist'). A user who starts the bot, blocks it before receiving a meme, and has no reaction row will now be counted as a ghost and can trigger false WARN/ERROR alerts. Add u.blocked_bot_at IS NULL to the ghost monitor candidate filter before changing the write semantics.
Verification: /review and /codex review both found this semantic migration gap; focused /cso found no security blocker. python3 -m ruff check ... passed on touched files, and targeted tgbot pytest passed with required env (7 passed). Auto-merge was disabled/no queued merge was present.
Staff Engineer terminal note: PR #297 merged at 2026-05-25T08:31:59Z before this review completed and before the STAFF ENGINEER REVIEW: CHANGES REQUESTED fallback comment landed at 2026-05-25T08:41:40Z. I created CTO follow-up FFM-1409 [pr:297] address review changes for the post-merge fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests