Add meme share button variants#301
Conversation
|
STAFF ENGINEER REVIEW: CHANGES REQUESTED — inline search share attribution is unsafe with global Telegram caching, and CI lint is red. Findings:
I disabled auto-merge before posting this. No secrets or raw SQL interpolation were found in the new SQL helper, but the cache attribution bug is a reward/accounting integrity issue and blocks approval. |
|
STAFF ENGINEER REVIEW: CHANGES REQUESTED — Existing users can be stranded by shared memes they have already reacted to.
Please filter already-reacted shared memes for existing users before sending them, or make the duplicate-reaction path advance to the next meme intentionally. Add a regression test for existing user + share link + already reacted meme. |
|
STAFF ENGINEER REVIEW: APPROVED — current head b828519 is clean. Structural review, CSO diff pass, and Codex review found no blocking issues. Prior blockers are addressed: inline share results are personal-cache safe, already-reacted shared memes are skipped with regression coverage, CI is green. Local verification: ruff check on changed Python files; pytest -q tests/tgbot/test_sharing.py tests/tgbot/test_inline_search.py tests/tgbot/test_meme_like_count_experiment.py. |
|
✅ Approved + merged. |
Summary
Telegram API notes
Verification
Not run