Skip to content

feat: randomize meme button colors#303

Merged
ohld merged 2 commits into
productionfrom
codex/random-meme-button-colors
May 27, 2026
Merged

feat: randomize meme button colors#303
ohld merged 2 commits into
productionfrom
codex/random-meme-button-colors

Conversation

@ohld
Copy link
Copy Markdown
Member

@ohld ohld commented May 26, 2026

Summary: Adds random Telegram Bot API button styles to meme action buttons in private feed and group meme reactions, including share buttons under memes. Keeps compatibility with older local python-telegram-bot by serializing style via api_kwargs when needed. Tests: ruff check on touched files; pytest tests/tgbot/test_meme_like_count_experiment.py tests/tgbot/test_sharing.py tests/tgbot/test_group_meme_reaction.py. Broader pytest tests/tgbot was attempted but local DB hostname app_db was not resolvable in this environment.

@ohld
Copy link
Copy Markdown
Member Author

ohld commented May 26, 2026

STAFF ENGINEER REVIEW: APPROVED — Structural review clean. /review and Codex second opinion found no actionable correctness issues. CSO skipped because the diff only touches Telegram button rendering/tests, not sensitive surfaces. Merge remains blocked until CI is green; current blocker is lint formatting in tests/tgbot/test_meme_like_count_experiment.py.

@ohld
Copy link
Copy Markdown
Member Author

ohld commented May 26, 2026

❌ CI red — leaving merge blocked. Current blocker: ruff format --check src/ tests/ wants tests/tgbot/test_meme_like_count_experiment.py reformatted. Next push will re-trigger me.

@ohld
Copy link
Copy Markdown
Member Author

ohld commented May 27, 2026

STAFF ENGINEER REVIEW: APPROVED — Clean structural review. Telegram button style serialization preserves callback/url behavior; no SQL, secret, recommendation-weight, or sensitive-surface regressions found. Codex review found no discrete correctness issue. Local targeted checks: ruff passed; pytest tests/tgbot/test_meme_like_count_experiment.py tests/tgbot/test_sharing.py tests/tgbot/test_group_meme_reaction.py passed (15 tests).

@ohld ohld merged commit 0026d0f into production May 27, 2026
3 checks passed
@ohld
Copy link
Copy Markdown
Member Author

ohld commented May 27, 2026

✅ Approved + merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant