Convert from "deferred write" to resizing

Author: ffrostfall

CHANGELOG.md

@@ -4,6 +4,11 @@ This project uses [semantic versioning](https://semver.org/spec/v2.0.0.html).
 
 ---
 
+## version 0.3.1
+
+### Improvements
+- Rewrote serialization to use an allocator w/ resizing instead of using "deferred write" functions. Should be an incredibly large performance boost.
+
 ## version 0.3.0
 
 ### Added

dev/server/serverTests.server.luau

@@ -18,18 +18,6 @@ local data = {
 }
 
 RunService.Heartbeat:Connect(function()
-	--[[for i = 1, 100 do
-		ReplicatedStorage.RemoteEvent:FireAllClients({
-			a = false,
-			b = { true, false, false },
-			c = { { false }, { true } },
-			d = nil,
-			e = { [8] = 4 },
-			f = {
-				[Vector3.new(15, 15, 15)] = 2554,
-			},
-		})
-	end]]
 	debug.profilebegin("send")
 	for _ = 1, 100 do
 		testPackets.a:sendToAll(data)

src/dataTypes/array.luau

@@ -2,39 +2,41 @@ local bufferWriter = require(script.Parent.Parent.process.bufferWriter)
 local types = require(script.Parent.Parent.types)
 
 local u16 = bufferWriter.u16
+local alloc = bufferWriter.alloc
 
 --[[
 	Create a new array with the given dataTypeInterface
 ]]
-return function(valueType: types.dataTypeInterface<any>)
-	local valueWrite = valueType.write
-
-	return {
-		read = function(b: buffer, cursor: number)
-			local arrayLength = buffer.readu16(b, cursor)
-			local arrayCursor = cursor + 2
-			local array = {}
-
-			for _ = 1, arrayLength do
-				local item, length = valueType.read(b, arrayCursor)
-				table.insert(array, item)
-
-				arrayCursor += length
-			end
-
-			return array, (arrayCursor - cursor)
-		end,
-		write = function(cursor: number, value: any)
-			u16(cursor, #value) -- write length, 2 bytes
-			local arrayCursor = cursor + 2
-
-			for _, item in value do
-				-- add the length of the item to the cursor
-				arrayCursor += valueWrite(arrayCursor, item)
-			end
-
-			-- return size of the array: arrayCursor - cursor = size
-			return arrayCursor - cursor
-		end,
-	}
-end :: <T>(valueType: types.dataTypeInterface<T>) -> types.dataTypeInterface<{ [number]: T }>
+return function(
+		valueType: types.dataTypeInterface<
+			any
+		>
+	)
+		local valueWrite = valueType.write
+
+		return {
+			read = function(b: buffer, cursor: number)
+				local arrayLength = buffer.readu16(b, cursor)
+				local arrayCursor = cursor + 2
+				local array = {}
+
+				for _ = 1, arrayLength do
+					local item, length = valueType.read(b, arrayCursor)
+					table.insert(array, item)
+
+					arrayCursor += length
+				end
+
+				return array, (arrayCursor - cursor)
+			end,
+			write = function(value: any)
+				alloc(2)
+				u16(#value) -- write length, 2 bytes
+
+				for _, item in value do
+					-- add the length of the item to the cursor
+					valueWrite(item)
+				end
+			end,
+		}
+	end :: <T>(valueType: types.dataTypeInterface<T>) -> types.dataTypeInterface<{ [number]: T }>

src/dataTypes/bool.luau

@@ -3,6 +3,7 @@ local types = require(script.Parent.Parent.types)
 
 local btrue = bufferWriter.btrue
 local bfalse = bufferWriter.bfalse
+local alloc = bufferWriter.alloc
 
 local bool = {
 	--[[
@@ -14,8 +15,14 @@ local bool = {
 	read = function(b: buffer, cursor: number)
 		return buffer.readu8(b, cursor) == 1, 1
 	end,
-	write = function(cursor: number, value: boolean)
-		return if value then btrue(cursor) else bfalse(cursor)
+	write = function(value: boolean)
+		alloc(1)
+
+		if value then
+			btrue()
+		else
+			bfalse()
+		end
 	end,
 }
 

src/dataTypes/buff.luau

@@ -3,6 +3,7 @@ local types = require(script.Parent.Parent.types)
 
 local u16 = bufferWriter.u16
 local copy = bufferWriter.copy
+local dyn_alloc = bufferWriter.dyn_alloc
 
 local buff = {
 	read = function(b: buffer, cursor: number)
@@ -14,14 +15,13 @@ local buff = {
 
 		return freshBuffer, length + 2
 	end,
-	write = function(cursor: number, data: buffer)
+	write = function(data: buffer)
 		local length = buffer.len(data)
+		dyn_alloc(length + 2)
 
 		-- write the length of the buffer, then the buffer itself
-		u16(cursor, length)
-		copy(cursor + 2, data)
-
-		return length + 2
+		u16(length)
+		copy(data)
 	end,
 }
 

src/dataTypes/cframe.luau

@@ -2,6 +2,7 @@ local bufferWriter = require(script.Parent.Parent.process.bufferWriter)
 local types = require(script.Parent.Parent.types)
 
 local f32 = bufferWriter.f32
+local alloc = bufferWriter.alloc
 
 -- thanks jack :p
 local cframe = {
@@ -19,7 +20,7 @@ local cframe = {
 
 		return CFrame.fromAxisAngle(axis, angle) + Vector3.new(x, y, z), 24
 	end,
-	write = function(cursor: number, value: CFrame)
+	write = function(value: CFrame)
 		-- Convert the CFrame to an axis-angle representation
 		local x, y, z = value.X, value.Y, value.Z
 
@@ -28,14 +29,13 @@ local cframe = {
 		axis = axis * angle
 
 		-- Math done, write it now
-		f32(cursor, x)
-		f32(cursor + 4, y)
-		f32(cursor + 8, z)
-		f32(cursor + 12, rx)
-		f32(cursor + 16, ry)
-		f32(cursor + 20, rz)
-
-		return 24
+		alloc(24)
+		f32(x)
+		f32(y)
+		f32(z)
+		f32(rx)
+		f32(ry)
+		f32(rz)
 	end,
 }
 

src/dataTypes/float32.luau

@@ -2,9 +2,13 @@ local bufferWriter = require(script.Parent.Parent.process.bufferWriter)
 local types = require(script.Parent.Parent.types)
 
 local f32 = bufferWriter.f32
+local alloc = bufferWriter.alloc
 
 local float32 = {
-	write = f32,
+	write = function(value: number)
+		alloc(4)
+		f32(value)
+	end,
 
 	read = function(b: buffer, cursor: number)
 		return buffer.readf32(b, cursor), 4

src/dataTypes/float64.luau

@@ -2,9 +2,13 @@ local bufferWriter = require(script.Parent.Parent.process.bufferWriter)
 local types = require(script.Parent.Parent.types)
 
 local f64 = bufferWriter.f64
+local alloc = bufferWriter.f64
 
 local float64 = {
-	write = f64,
+	write = function(value: number)
+		alloc(8)
+		f64(value)
+	end,
 
 	read = function(b: buffer, cursor: number)
 		return buffer.readf64(b, cursor), 8

src/dataTypes/int16.luau

@@ -2,9 +2,13 @@ local bufferWriter = require(script.Parent.Parent.process.bufferWriter)
 local types = require(script.Parent.Parent.types)
 
 local i16 = bufferWriter.i16
+local alloc = bufferWriter.alloc
 
 local int16 = {
-	write = i16,
+	write = function(value: number)
+		alloc(8)
+		i16(value)
+	end,
 
 	read = function(b: buffer, cursor: number)
 		return buffer.readi16(b, cursor), 2

src/dataTypes/int32.luau

@@ -2,9 +2,13 @@ local bufferWriter = require(script.Parent.Parent.process.bufferWriter)
 local types = require(script.Parent.Parent.types)
 
 local i32 = bufferWriter.i32
+local alloc = bufferWriter.alloc
 
 local int32 = {
-	write = i32,
+	write = function(value: number)
+		alloc(4)
+		i32(value)
+	end,
 
 	read = function(b: buffer, cursor: number)
 		return buffer.readi32(b, cursor), 4