Fix break reminder showing malformed 'Next:' output#47
Merged
Conversation
- Check meeting is in future (> now_ms) not just non-zero - Omit "Next:" suffix entirely when no upcoming meeting - Fallback title to "meeting" if calendar entry has empty title - Clean output: "☕ 771m focus. Break?" or with meeting: "☕ 771m focus. Break? Next: Standup in 45m" Fixes issue where stale/past meetings caused "Next: nothing in ∞m"
af906e3 to
f25cfe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_focus_break()inrefresh-daemon.shto handle missing/stale calendar data gracefully> now_ms) not just non-zero to avoid past meetingsBefore
After
Or with a valid meeting:
Test plan
test-focus.shpasses (19/19 tests)