fix: Thread-Safety Queue.pending+status_counts, i18n locale.Error-Fallback (Bugsweep)

Bug 1 (models.py): Queue.pending property iterierte self.tasks ohne Lock --
Race Condition wenn UI-Thread add() und Worker-Thread pending lesen gleichzeitig.
Fix: pending unter self._lock; neue status_counts()-Methode fuer _refresh_status.

Bug 2 (tray.py + models.py): _refresh_status() iterierte self.queue.tasks direkt
ohne Lock (Zeile 273). Fix: status_counts() gibt (n_pending, n_failed) atomar
unter Lock zurueck; tray.py nutzt status_counts() statt direktem tasks-Zugriff.

Bug 3 (i18n.py): detect_language() fing nur ValueError/TypeError -- locale.Error
(Subclass von Exception) konnte ungefangen eskalieren auf Systemen mit kaputtem
Locale. Fix: except Exception mit Kommentar.

Tests: 3 neue Tests (test_queue_status_counts_thread_safe,
test_queue_pending_property_thread_safe, test_detect_language_locale_error_falls_back_to_german).
95/95 gruen.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Lukas Geiger

src/cloudlockfixer/i18n.py

@@ -293,7 +293,9 @@ def detect_language() -> Language:
         lang, _ = locale.getlocale()
         if lang and lang.lower().startswith("en"):
             return "en"
-    except (ValueError, TypeError):
+    except Exception:
+        # locale.Error (Subclass von Exception) und ValueError/TypeError
+        # bei ungültiger oder nicht gesetzter System-Locale abfangen.
         pass
     return "de"
 

src/cloudlockfixer/models.py

@@ -182,7 +182,20 @@ def add(self, task: Task) -> Task:
 
     @property
     def pending(self) -> list[Task]:
-        return [t for t in self.tasks if t.status in ("pending", "running")]
+        with self._lock:
+            return [t for t in self.tasks if t.status in ("pending", "running")]
+
+    def status_counts(self) -> tuple[int, int]:
+        """(n_pending, n_failed_with_retries) — Thread-sicher unter Lock."""
+        with self._lock:
+            n_pending = sum(
+                1 for t in self.tasks if t.status in ("pending", "running")
+            )
+            n_failed = sum(
+                1 for t in self.tasks
+                if t.status == "pending" and t.retry_count > 0
+            )
+            return n_pending, n_failed
 
     def save(self) -> None:
         with self._lock:

src/cloudlockfixer/tray.py

@@ -269,9 +269,7 @@ def _set_status(self, text: str) -> None:
     def _refresh_status(self) -> None:
         if not self._running:
             self.queue.load()
-        n = len(self.queue.pending)
-        failed = sum(1 for t_ in self.queue.tasks
-                     if t_.status == "pending" and t_.retry_count > 0)
+        n, failed = self.queue.status_counts()
         txt = (t("status_no_tasks") if n == 0
                else t("status_open", n=n, failed=failed))
         self._set_status(txt)

tests/test_core.py

@@ -296,6 +296,43 @@ def test_worker_runs_local_task(tmp_path):
     assert (tmp_path / "new").exists()
 
 
+def test_queue_status_counts_thread_safe(tmp_path):
+    """Bug-Fix (Bug-Sweep): status_counts() muss Thread-sicher unter Lock laufen.
+    pending-Property und tasks-Direktzugriff in _refresh_status ersetzt durch
+    status_counts() um Race Condition zwischen UI- und Worker-Thread zu vermeiden."""
+    q = Queue(tmp_path)
+    # Leere Queue
+    n_pending, n_failed = q.status_counts()
+    assert n_pending == 0 and n_failed == 0
+
+    # Einen Task hinzufügen
+    src = _mkdir_with_file(tmp_path / "src1")
+    t1 = Task(chain=[Step(op="rename", src=str(src), arg="dst1")])
+    q.add(t1)
+    n_pending, n_failed = q.status_counts()
+    assert n_pending == 1 and n_failed == 0
+
+    # retry_count > 0 -> zählt als "failed_with_retries"
+    q.tasks[0].retry_count = 1
+    n_pending, n_failed = q.status_counts()
+    assert n_pending == 1 and n_failed == 1
+
+    # Status "done" -> nicht mehr pending
+    q.tasks[0].status = "done"
+    n_pending, n_failed = q.status_counts()
+    assert n_pending == 0 and n_failed == 0
+
+
+def test_queue_pending_property_thread_safe(tmp_path):
+    """Bug-Fix (Bug-Sweep): pending-Property muss Lock halten beim Lesen von tasks."""
+    q = Queue(tmp_path)
+    src = _mkdir_with_file(tmp_path / "src2")
+    q.add(Task(chain=[Step(op="rename", src=str(src), arg="dst2")]))
+    pending = q.pending
+    assert len(pending) == 1
+    assert pending[0].status == "pending"
+
+
 # ── CLI ─────────────────────────────────────────────────────────────
 
 def test_cli_chain_invalid_op_returns_2(tmp_path, monkeypatch):

tests/test_i18n.py

@@ -73,6 +73,19 @@ def test_detect_language_fallback(monkeypatch):
     assert detect_language() == "de"
 
 
+def test_detect_language_locale_error_falls_back_to_german(monkeypatch):
+    """Bug-Fix: locale.getlocale() kann locale.Error werfen (Subclass von Exception,
+    nicht von ValueError/TypeError). Muss sicher auf 'de' zurückfallen."""
+    import locale as locale_mod
+
+    def raise_locale_error():
+        raise locale_mod.Error("Ungültige Locale-Konfiguration")
+
+    monkeypatch.setattr("locale.getlocale", raise_locale_error)
+    result = detect_language()
+    assert result == "de", f"Erwartet 'de' als Fallback bei locale.Error, war: {result}"
+
+
 def test_available_keys_sorted():
     keys = available_keys()
     assert keys == sorted(keys)