Default the Oracle embedders' proxy argument to None#1
Open
RichmondAlake wants to merge 1 commit into
Open
Conversation
OracleTextEmbedder and OracleDocumentEmbedder declared proxy as a required keyword-only argument despite documenting it as optional, so constructing either without it raised 'TypeError: missing 1 required keyword-only argument: proxy' — which any standard RAG pipeline hits immediately. proxy is keyword-only, so defaulting it to None is backward compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OracleTextEmbedderandOracleDocumentEmbedderdeclareproxy: Any | Noneas a required keyword-only argument, despite documenting it as "Optional HTTP proxy…". Constructing either embedder the normal way:raises:
This bites any standard usage / RAG pipeline. The existing tests don't catch it because they always pass
proxyexplicitly.Fix
Default
proxytoNonein both embedder constructors (one word each).proxyis keyword-only, so this is fully backward compatible.Verification
Against Oracle AI Database 26ai Free with the in-DB
ALL_MINILM_L12_V2model:proxy; live embedding returns 384-dim vectors.OracleDocumentEmbedder→OracleDocumentStore→OracleEmbeddingRetriever→OpenAIGenerator) runs without theproxy=Noneworkaround.🤖 Generated with Claude Code