Skip to content

Default the Oracle embedders' proxy argument to None#1

Open
RichmondAlake wants to merge 1 commit into
fileames:oracle_integrationfrom
RichmondAlake:fix/oracle-embedder-proxy-default
Open

Default the Oracle embedders' proxy argument to None#1
RichmondAlake wants to merge 1 commit into
fileames:oracle_integrationfrom
RichmondAlake:fix/oracle-embedder-proxy-default

Conversation

@RichmondAlake

Copy link
Copy Markdown

What

OracleTextEmbedder and OracleDocumentEmbedder declare proxy: Any | None as a required keyword-only argument, despite documenting it as "Optional HTTP proxy…". Constructing either embedder the normal way:

OracleDocumentEmbedder(connection_params=..., embedding_params=...)

raises:

TypeError: OracleDocumentEmbedder.__init__() missing 1 required keyword-only argument: 'proxy'

This bites any standard usage / RAG pipeline. The existing tests don't catch it because they always pass proxy explicitly.

Fix

Default proxy to None in both embedder constructors (one word each). proxy is keyword-only, so this is fully backward compatible.

Verification

Against Oracle AI Database 26ai Free with the in-DB ALL_MINILM_L12_V2 model:

  • Both embedders now construct without proxy; live embedding returns 384-dim vectors.
  • Unit suite: 182 passed (no regression).
  • A full RAG pipeline (OracleDocumentEmbedderOracleDocumentStoreOracleEmbeddingRetrieverOpenAIGenerator) runs without the proxy=None workaround.

🤖 Generated with Claude Code

OracleTextEmbedder and OracleDocumentEmbedder declared proxy as a required keyword-only argument despite documenting it as optional, so constructing either without it raised 'TypeError: missing 1 required keyword-only argument: proxy' — which any standard RAG pipeline hits immediately. proxy is keyword-only, so defaulting it to None is backward compatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant