schemas: string keys for keyed unions#516
Closed
rvagg wants to merge 1 commit into
Closed
Conversation
IPLD doesn't support non-string keys for maps which is how kinded unions are stored. Switch instead to string keys. Ref: https://github.com/ipld/specs/blob/data-model-motivation/data-model-layer/data-model.md#motivation Ref: ipld/specs#184 (comment) Ref: ipld/specs#58
warpfork
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(one of a few PRs to attempt to get the IPLD Schemas conforming to current spec)
IPLD doesn't support non-string keys for maps which is how kinded unions are stored. Switch instead to string keys.
I'm not expecting this to be uncontroversial because an extra byte gets involved in the encoding here and I know that's an important consideration, but we're bumping up against the IPLD goal of providing a common data interface able to support multiple encoding formats and multiple programming languages. Integer map keys are comfortable from Go -> CBOR but become awkward as we move away from that pairing.
Ref: https://github.com/ipld/specs/blob/data-model-motivation/data-model-layer/data-model.md#motivation
Ref: ipld/specs#184 (comment)
Ref: ipld/specs#58