Skip to content

Commit 48e97f2

Browse files
yair100claude
andauthored
Fix: Enabled Play action for single media file selection (#18520)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0fd162c commit 48e97f2

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

src/Files.App/Actions/Content/PlayAllAction.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ internal sealed partial class PlayAllAction : ObservableObject, IAction
1111
private readonly IContentPageContext context;
1212

1313
public string Label
14-
=> Strings.PlayAll.GetLocalizedResource();
14+
=> context.SelectedItems.Count > 1
15+
? Strings.PlayAll.GetLocalizedResource()
16+
: Strings.Play.GetLocalizedResource();
1517

1618
public string Description
1719
=> Strings.PlayAllDescription.GetLocalizedResource();
@@ -24,7 +26,7 @@ public RichGlyph Glyph
2426

2527
public bool IsExecutable =>
2628
context.PageType != ContentPageTypes.RecycleBin &&
27-
context.SelectedItems.Count > 1 &&
29+
context.SelectedItems.Count > 0 &&
2830
context.SelectedItems.All(item => FileExtensionHelpers.IsMediaFile(item.FileExtension));
2931

3032
public PlayAllAction()
@@ -46,6 +48,7 @@ private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
4648
case nameof(IContentPageContext.PageType):
4749
case nameof(IContentPageContext.SelectedItems):
4850
OnPropertyChanged(nameof(IsExecutable));
51+
OnPropertyChanged(nameof(Label));
4952
break;
5053
}
5154
}

src/Files.App/Strings/en-US/Resources.resw

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2412,6 +2412,9 @@
24122412
<value>Are you sure you want to delete this tag?</value>
24132413
</data>
24142414
<data name="PlayAll" xml:space="preserve">
2415+
<value>Play All</value>
2416+
</data>
2417+
<data name="Play" xml:space="preserve">
24152418
<value>Play</value>
24162419
</data>
24172420
<data name="Height" xml:space="preserve">

src/Files.Shared/Helpers/FileExtensionHelpers.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,8 @@ public static bool IsMediaFile(string? filePathToCheck)
259259
{
260260
return HasExtension(
261261
filePathToCheck, ".mp4", ".m4v", ".mp4v", ".3g2", ".3gp2", ".3gp", ".3gpp",
262-
".mpg", ".mp2", ".mpeg", ".mpe", ".mpv", ".mkv", ".ogg", ".avi", ".wmv", ".mov", ".qt");
262+
".mpg", ".mp2", ".mpeg", ".mpe", ".mpv", ".mkv", ".ogg", ".avi", ".wmv", ".mov", ".qt",
263+
".mp3", ".m4a", ".oga", ".wav", ".wma", ".aac", ".flac");
263264
}
264265

265266
/// <summary>

0 commit comments

Comments
 (0)