Code Quality: Moved GetRepositoryHead operation into Git abstraction (#18505)

Author: Lamparter

src/Files.App/Utils/Git/GitHelpers.cs

@@ -25,6 +25,9 @@ internal static partial class GitHelpers
 		/// <inheritdoc cref="IVersionControl.GetBranchNames(string?)"/>
 		public static Task<BranchItem[]> GetBranchNames(string? path) => _implementation.GetBranchNames(path);
 
+		/// <inheritdoc cref="IVersionControl.GetRepositoryHead(string?)"/>
+		public static Task<BranchItem?> GetRepositoryHead(string? path) => _implementation.GetRepositoryHead(path);
+
 		#region Legacy implementation
 
 		// Property already moved into abstraction
@@ -91,38 +94,6 @@ private set
 		// Event handler already moved into abstraction
 		public static event EventHandler? GitFetchCompleted;
 
-		public static async Task<BranchItem?> GetRepositoryHead(string? path)
-		{
-			if (string.IsNullOrWhiteSpace(path) || !IsRepoValid(path))
-				return null;
-
-			var (_, returnValue) = await DoGitOperationAsync<(GitOperationResult, BranchItem?)>(() =>
-			{
-				BranchItem? head = null;
-				try
-				{
-					using var repository = new Repository(path);
-					var branch = GetValidBranches(repository.Branches).FirstOrDefault(b => b.IsCurrentRepositoryHead);
-					if (branch is not null)
-						head = new BranchItem(
-							branch.FriendlyName,
-							branch.IsCurrentRepositoryHead,
-							branch.IsRemote,
-							TryGetTrackingDetails(branch)?.AheadBy ?? 0,
-							TryGetTrackingDetails(branch)?.BehindBy ?? 0
-						);
-				}
-				catch
-				{
-					return (GitOperationResult.GenericError, head);
-				}
-
-				return (GitOperationResult.Success, head);
-			}, true);
-
-			return returnValue;
-		}
-
 		public static async Task<bool> Checkout(string? repositoryPath, string? branch)
 		{
 			// Re-enable when Metris feature is available again

src/Files.App/Utils/Git/LibGit2.cs

@@ -127,6 +127,38 @@ public async Task<BranchItem[]> GetBranchNames(string? path)
 		return returnValue;
 	}
 
+	public async Task<BranchItem?> GetRepositoryHead(string? path)
+	{
+		if (string.IsNullOrWhiteSpace(path) || !IsRepoValid(path))
+			return null;
+
+		var (_, returnValue) = await DoGitOperationAsync<(GitOperationResult, BranchItem?)>(() =>
+		{
+			BranchItem? head = null;
+			try
+			{
+				using var repository = new Repository(path);
+				var branch = GetValidBranches(repository.Branches).FirstOrDefault(b => b.IsCurrentRepositoryHead);
+				if (branch is not null)
+					head = new BranchItem(
+						branch.FriendlyName,
+						branch.IsCurrentRepositoryHead,
+						branch.IsRemote,
+						TryGetTrackingDetails(branch)?.AheadBy ?? 0,
+						TryGetTrackingDetails(branch)?.BehindBy ?? 0
+					);
+			}
+			catch
+			{
+				return (GitOperationResult.GenericError, head);
+			}
+
+			return (GitOperationResult.Success, head);
+		}, true);
+
+		return returnValue;
+	}
+
 	private static bool IsRepoValid(string path)
 	{
 		return SafetyExtensions.IgnoreExceptions(() => Repository.IsValid(path));