Feature: Added media duration to tooltips (#18371)

Author: yair100

src/Files.App/Data/Items/ListedItem.cs

@@ -51,6 +51,8 @@ public string ItemTooltipText
 					tooltipBuilder.Append($"{Environment.NewLine}{Strings.SizeLabel.GetLocalizedResource()} {FileSize}");
 				if (!string.IsNullOrWhiteSpace(ImageDimensions))
 					tooltipBuilder.Append($"{Environment.NewLine}{Strings.PropertyDimensionsColon.GetLocalizedResource()} {ImageDimensions}");
+				if (!string.IsNullOrWhiteSpace(MediaDuration))
+					tooltipBuilder.Append($"{Environment.NewLine}{Strings.PropertyDuration.GetLocalizedResource()}: {MediaDuration}");
 				if (SyncStatusUI.LoadSyncStatus)
 					tooltipBuilder.Append($"{Environment.NewLine}{Strings.StatusWithColon.GetLocalizedResource()} {syncStatusUI.SyncStatusString}");
 

src/Files.App/Views/Layouts/BaseLayoutPage.cs

@@ -1206,6 +1206,7 @@ protected void FileList_ContainerContentChanging(ListViewBase sender, ContainerC
 
 		private void RefreshContainer(SelectorItem container, bool inRecycleQueue)
 		{
+			container.Loaded -= FileListItem_Loaded;
 			container.PointerPressed -= FileListItem_PointerPressed;
 			container.PointerEntered -= FileListItem_PointerEntered;
 			container.PointerExited -= FileListItem_PointerExited;
@@ -1219,6 +1220,7 @@ private void RefreshContainer(SelectorItem container, bool inRecycleQueue)
 			}
 			else
 			{
+				container.Loaded += FileListItem_Loaded;
 				container.PointerPressed += FileListItem_PointerPressed;
 				container.PointerEntered += FileListItem_PointerEntered;
 				container.PointerExited += FileListItem_PointerExited;
@@ -1235,10 +1237,12 @@ private void RefreshItem(SelectorItem container, object item, bool inRecycleQueu
 
 			if (inRecycleQueue)
 			{
+				UpdateItemToolTip(container, null);
 				ParentShellPageInstance!.ShellViewModel.CancelExtendedPropertiesLoadingForItem(listedItem);
 			}
 			else
 			{
+				UpdateItemToolTip(container, listedItem.ItemTooltipText);
 				InitializeDrag(container, listedItem);
 
 				if (listedItem.PreloadedIconData is not null && listedItem.FileImage is null)
@@ -1257,6 +1261,32 @@ private void RefreshItem(SelectorItem container, object item, bool inRecycleQueu
 			}
 		}
 
+		private static void UpdateItemToolTip(SelectorItem container, string? tooltipText)
+		{
+			// Apply the tooltip to both the container and the realized template root so every layout
+			// gets the same behavior, even when the DataTemplate is wrapped in a UserControl.
+			UpdateItemToolTip(container as FrameworkElement, tooltipText);
+
+			if (container.ContentTemplateRoot is FrameworkElement contentTemplateRoot)
+				UpdateItemToolTip(contentTemplateRoot, tooltipText);
+		}
+
+		private static void UpdateItemToolTip(FrameworkElement? target, string? tooltipText)
+		{
+			if (target is null)
+				return;
+
+			ToolTipService.SetToolTip(target, tooltipText);
+			target.SetValue(ToolTipService.PlacementProperty, PlacementMode.Mouse);
+		}
+
+		private void FileListItem_Loaded(object sender, RoutedEventArgs e)
+		{
+			// Set the initial tooltip before hover starts so WinUI doesn't miss the first dwell.
+			if (sender is SelectorItem container && container.Content is ListedItem listedItem)
+				UpdateItemToolTip(container, listedItem.ItemTooltipText);
+		}
+
 		private static async Task ApplyPreloadedIconAsync(ListedItem item)
 		{
 			var image = await item.PreloadedIconData.ToBitmapAsync();
@@ -1299,6 +1329,9 @@ protected internal void FileListItem_PointerEntered(object sender, PointerRouted
 			if (sender is SelectorItem selectorItem && selectorItem.IsSelected)
 				MainWindow.Instance.SetCanWindowToFront(false);
 
+			if (sender is SelectorItem tooltipContainer && tooltipContainer.Content is ListedItem listedItem)
+				UpdateItemToolTip(tooltipContainer, listedItem.ItemTooltipText);
+
 			if (!UserSettingsService.FoldersSettingsService.SelectFilesOnHover)
 				return;
 

src/Files.App/Views/Layouts/ColumnLayoutPage.xaml

@@ -216,8 +216,7 @@
 								VerticalAlignment="Center"
 								CornerRadius="{StaticResource ControlCornerRadius}"
 								IsRightTapEnabled="True"
-								Loaded="Grid_Loaded"
-								PointerEntered="Grid_PointerEntered">
+								Loaded="Grid_Loaded">
 								<Grid.ColumnDefinitions>
 									<ColumnDefinition Width="Auto" />
 									<ColumnDefinition Width="*" />

src/Files.App/Views/Layouts/ColumnLayoutPage.xaml.cs

@@ -574,13 +574,6 @@ private void Grid_Loaded(object sender, RoutedEventArgs e)
 			itemContainer.ContextFlyout = ItemContextMenuFlyout;
 		}
 
-		private void Grid_PointerEntered(object sender, PointerRoutedEventArgs e)
-		{
-			if (sender is FrameworkElement element && element.DataContext is ListedItem item)
-				// Reassign values to update date display
-				ToolTipService.SetToolTip(element, item.ItemTooltipText);
-		}
-
 		protected override void BaseFolderSettings_LayoutModeChangeRequested(object? sender, LayoutModeEventArgs e)
 		{
 			var parent = this.FindAscendant<ModernShellPage>();

src/Files.App/Views/Layouts/DetailsLayoutPage.xaml

@@ -1001,8 +1001,6 @@
 											x:Name="ItemName"
 											Padding="6,0,0,0"
 											VerticalAlignment="Center"
-											DataContextChanged="TextBlock_DataContextChanged"
-											IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
 											Opacity="{x:Bind Opacity, Mode=OneWay}"
 											Text="{x:Bind Name, Mode=OneWay}"
 											TextTrimming="CharacterEllipsis" />

src/Files.App/Views/Layouts/GridLayoutPage.xaml

@@ -100,8 +100,7 @@
 					tui:FrameworkElementExtensions.EnableActualSizeBinding="True"
 					Background="Transparent"
 					IsRightTapEnabled="True"
-					Loaded="Grid_Loaded"
-					PointerEntered="Grid_PointerEntered">
+					Loaded="Grid_Loaded">
 					<Grid.RowDefinitions>
 						<RowDefinition Height="Auto" />
 						<RowDefinition Height="*" />
@@ -282,8 +281,7 @@
 					VerticalAlignment="Center"
 					CornerRadius="{StaticResource ControlCornerRadius}"
 					IsRightTapEnabled="True"
-					Loaded="Grid_Loaded"
-					PointerEntered="Grid_PointerEntered">
+					Loaded="Grid_Loaded">
 					<Grid.ColumnDefinitions>
 						<ColumnDefinition Width="Auto" />
 						<ColumnDefinition Width="*" />
@@ -442,8 +440,7 @@
 					BorderThickness="1"
 					CornerRadius="8"
 					IsRightTapEnabled="True"
-					Loaded="Grid_Loaded"
-					PointerEntered="Grid_PointerEntered">
+					Loaded="Grid_Loaded">
 					<StackPanel Orientation="{Binding ElementName=PageRoot, Path=CardsViewOrientation, Mode=OneWay}">
 
 						<!--  Preview  -->

src/Files.App/Views/Layouts/GridLayoutPage.xaml.cs

@@ -756,13 +756,6 @@ private void Grid_Loaded(object sender, RoutedEventArgs e)
 			}
 		}
 
-		private void Grid_PointerEntered(object sender, PointerRoutedEventArgs e)
-		{
-			if (sender is FrameworkElement element && element.DataContext is ListedItem item)
-				// Reassign values to update date display
-				ToolTipService.SetToolTip(element, item.ItemTooltipText);
-		}
-
 		private void SelectionCheckbox_PointerEntered(object sender, PointerRoutedEventArgs e)
 		{
 			UpdateCheckboxVisibility((sender as FrameworkElement)!.FindAscendant<GridViewItem>()!, true);