Code Quality: Simplified logic for adaptive layout#18322
Merged
yair100 merged 6 commits intofiles-community:mainfrom Apr 10, 2026
Merged
Conversation
yair100
reviewed
Mar 31, 2026
yair100
reviewed
Mar 31, 2026
Member
Author
|
Could also remove the below as it's now only using one value from it for adaptive layout helper |
yair100
added
ready for review
Member
|
Agreed |
Josh65-2201
changed the title
yair100
changed the title
yair100
changed the title
yair100
added
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
Added .ogg (.oga is the same format just different file extension) to the isAudio check. Was only in the isVideo check and as it can have video in it (although rarely) I have kept it there.
Note that the existing isMedia checks audio and video files in a folder. Since audio can have album art for the thumbnail I believe it's fine to have them also use grid layout