Code Quality: Fixed an issue where the "This app can't run on your PC" dialogue displayed inappropriately#18739
Merged
Merged
Conversation
Lamparter
marked this pull request as ready for review
July 19, 2026 06:39
yair100
reviewed
Jul 19, 2026
Co-authored-by: yair100 <39923744+yair100@users.noreply.github.com> Signed-off-by: Jupiter <71598437+Lamparter@users.noreply.github.com>
yair100
added
ready for review
yair100
added
ready to merge
yair100
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
Note that creating an executable file with no contents will not result in the dialogue showing anymore. However, this is justified by the fact that in practice, a user will never be opening an executable file with no binary contents unless they are just playing around with their PC.