Skip to content

Fix: Fixed an issue where activating the app by URI sometimes caused a crash#18746

Open
Lamparter wants to merge 2 commits into
files-community:mainfrom
Lamparter:app-activation
Open

Fix: Fixed an issue where activating the app by URI sometimes caused a crash#18746
Lamparter wants to merge 2 commits into
files-community:mainfrom
Lamparter:app-activation

Conversation

@Lamparter

Copy link
Copy Markdown
Contributor

Resolved / Related Issues

Steps used to test these changes

  • Activating the app with an 'open path' argument now results in the correct activation sequence (this means that pinning items now works correctly again, and does not silently fail)

    Method 1

    1. Opened Windows Terminal
    2. Entered files-dev.exe "C:\Windows\Web\4K\Wallpaper\Windows\img0_1920x1200.jpg" (for example)
    3. Observed that the Windows 11 bloom image opens

    Method 2

    1. Opened the Run dialogue box via Win+R
    2. Entered a protocol such as files-dev:?cmd=-Cmdless%20C%3A%5CWindows%5CWeb%5C4K%5CWallpaper%5CWindows%5Cimg0_1920x1200.jpg
    3. Observed that the Windows 11 bloom image opens
  • Activating the app via an invalid URI protocol no longer crashes the app

    1. Opened the Run dialogue box via Win+R
    2. Entered an (invalid) app protocol URI, e.g. files-dev:test or files-dev://
    3. Observed that the app launches normally without crashing (see Bug: Activating the app from its URI/CLI sometimes causes a crash #18743 for more info)
  • Activating the app by protocol / command line now correctly brings it to the foreground

    1. Opened the app
    2. Open another app and ensure that Files is not in the foreground
    3. Opened the Run dialogue box via Win+R
    4. Entered an app protocol URI, e.g. files-dev:, or optionally an executable command, e.g. files.exe
    5. Observed that the Files app is brought to the foreground

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Activating the app from its URI/CLI sometimes causes a crash

1 participant