fix: change primary base color from pink to black#307
Conversation
Replaced the 'pink' color entry in _variables.scss with 'black' and updated all shade references (50-950) and color/hoverColor/activeColor in the primary theme config accordingly. Fixes filiptrivan#305
filiptrivan
left a comment
There was a problem hiding this comment.
Hey, thanks for reading the contributor guide and getting the project running locally, really appreciate that.
The committed change only renames "pink" to "black" in the $colors map in _variables.scss. That map isn't referenced anywhere in the codebase, so this line has no effect on the theme.
The pink primary actually comes from GetPrimeNGThemeTsData() in Spiderly.Shared/Helpers/NetAndAngularFilesGenerator.cs, where the preset maps primary to the {pink.*} tokens. Judging by your screenshot you probably already changed that locally, but it didn't make it into the commit.
One thing to watch out for: PrimeNG has no built-in black palette, so {black.50}...{black.950} won't resolve. The usual way to get a black theme is to map primary to {zinc.*} with color: '{zinc.950}', like PrimeNG's Noir preset does.
Could you update the PR with the generator change and revert the _variables.scss line? Happy to merge after that.
|
Thank you for your comments! I have updated the GetPrimeNGThemeTsData() function in order to make use of the zinc palette and reverted all changes made in _variables.scss files. I also have verified the build of the Angular library. |
Replaced the 'pink' color entry in _variables.scss with 'black' and updated all shade references (50-950) and color/hoverColor/activeColor in the primary theme config accordingly.
Screenshot :

Fixes #305