Skip to content

fix: change primary base color from pink to black#307

Merged
filiptrivan merged 2 commits into
filiptrivan:mainfrom
adityaraut649:fix/305-black-base-color
Jul 8, 2026
Merged

fix: change primary base color from pink to black#307
filiptrivan merged 2 commits into
filiptrivan:mainfrom
adityaraut649:fix/305-black-base-color

Conversation

@adityaraut649

@adityaraut649 adityaraut649 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Replaced the 'pink' color entry in _variables.scss with 'black' and updated all shade references (50-950) and color/hoverColor/activeColor in the primary theme config accordingly.

Screenshot :
image

Fixes #305

Replaced the 'pink' color entry in _variables.scss with 'black' and updated all shade references (50-950) and color/hoverColor/activeColor in the primary theme config accordingly.

Fixes filiptrivan#305

@filiptrivan filiptrivan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for reading the contributor guide and getting the project running locally, really appreciate that.

The committed change only renames "pink" to "black" in the $colors map in _variables.scss. That map isn't referenced anywhere in the codebase, so this line has no effect on the theme.

The pink primary actually comes from GetPrimeNGThemeTsData() in Spiderly.Shared/Helpers/NetAndAngularFilesGenerator.cs, where the preset maps primary to the {pink.*} tokens. Judging by your screenshot you probably already changed that locally, but it didn't make it into the commit.

One thing to watch out for: PrimeNG has no built-in black palette, so {black.50}...{black.950} won't resolve. The usual way to get a black theme is to map primary to {zinc.*} with color: '{zinc.950}', like PrimeNG's Noir preset does.

Could you update the PR with the generator change and revert the _variables.scss line? Happy to merge after that.

@adityaraut649

Copy link
Copy Markdown
Contributor Author

Thank you for your comments! I have updated the GetPrimeNGThemeTsData() function in order to make use of the zinc palette and reverted all changes made in _variables.scss files. I also have verified the build of the Angular library.

@adityaraut649
adityaraut649 requested a review from filiptrivan July 8, 2026 17:26
@filiptrivan
filiptrivan merged commit 5e48ed6 into filiptrivan:main Jul 8, 2026
5 checks passed
@adityaraut649
adityaraut649 deleted the fix/305-black-base-color branch July 9, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change the base colour to black instead of pink

2 participants