Skip to content

Commit a854134

Browse files
committed
Bump OrderedFlaot dependency to 2.0.
1 parent 479b768 commit a854134

2 files changed

Lines changed: 14 additions & 17 deletions

File tree

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ byteorder = "1"
2020
fnv = "1"
2121
itertools = "0.9"
2222
ndarray = "0.13"
23-
ordered-float = "1"
23+
ordered-float = "2"
2424
rand = "0.7"
2525
rand_xorshift = "0.2"
2626
reductive = "0.5"

src/similarity.rs

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,7 @@ mod tests {
305305
use std::io::BufReader;
306306

307307
use approx::AbsDiffEq;
308+
use ordered_float::NotNan;
308309

309310
use crate::compat::word2vec::ReadWord2Vec;
310311
use crate::embeddings::Embeddings;
@@ -413,25 +414,25 @@ mod tests {
413414
fn cosine_similarity_is_correctly_converted_to_angular_similarity() {
414415
assert!((WordSimilarityResult {
415416
word: "test",
416-
similarity: 1f32.into()
417+
similarity: NotNan::new(1f32).unwrap()
417418
})
418419
.angular_similarity()
419420
.abs_diff_eq(&1f32, 1e-5));
420421
assert!((WordSimilarityResult {
421422
word: "test",
422-
similarity: 0.70710678.into()
423+
similarity: NotNan::new(0.70710678).unwrap()
423424
})
424425
.angular_similarity()
425426
.abs_diff_eq(&0.75, 1e-5));
426427
assert!((WordSimilarityResult {
427428
word: "test",
428-
similarity: 0f32.into()
429+
similarity: NotNan::new(0f32).unwrap()
429430
})
430431
.angular_similarity()
431432
.abs_diff_eq(&0.5f32, 1e-5));
432433
assert!((WordSimilarityResult {
433434
word: "test",
434-
similarity: (-1f32).into()
435+
similarity: NotNan::new(-1f32).unwrap()
435436
})
436437
.angular_similarity()
437438
.abs_diff_eq(&0f32, 1e-5));
@@ -441,25 +442,25 @@ mod tests {
441442
fn cosine_similarity_is_correctly_converted_to_euclidean_distance() {
442443
assert!((WordSimilarityResult {
443444
word: "test",
444-
similarity: 1f32.into()
445+
similarity: NotNan::new(1f32).unwrap()
445446
})
446447
.euclidean_distance()
447448
.abs_diff_eq(&0f32, 1e-5));
448449
assert!((WordSimilarityResult {
449450
word: "test",
450-
similarity: 0.70710678.into()
451+
similarity: NotNan::new(0.70710678).unwrap()
451452
})
452453
.euclidean_distance()
453454
.abs_diff_eq(&0.76537, 1e-5));
454455
assert!((WordSimilarityResult {
455456
word: "test",
456-
similarity: 0f32.into()
457+
similarity: NotNan::new(0f32).unwrap()
457458
})
458459
.euclidean_distance()
459460
.abs_diff_eq(&2f32.sqrt(), 1e-5));
460461
assert!((WordSimilarityResult {
461462
word: "test",
462-
similarity: (-1f32).into()
463+
similarity: NotNan::new(-1f32).unwrap()
463464
})
464465
.euclidean_distance()
465466
.abs_diff_eq(&2f32, 1e-5));
@@ -469,25 +470,25 @@ mod tests {
469470
fn cosine_similarity_is_correctly_converted_to_euclidean_similarity() {
470471
assert!((WordSimilarityResult {
471472
word: "test",
472-
similarity: 1f32.into()
473+
similarity: NotNan::new(1f32).unwrap()
473474
})
474475
.euclidean_similarity()
475476
.abs_diff_eq(&1f32, 1e-5));
476477
assert!((WordSimilarityResult {
477478
word: "test",
478-
similarity: 0.70710678.into()
479+
similarity: NotNan::new(0.70710678).unwrap()
479480
})
480481
.euclidean_similarity()
481482
.abs_diff_eq(&0.61732, 1e-5));
482483
assert!((WordSimilarityResult {
483484
word: "test",
484-
similarity: 0f32.into()
485+
similarity: NotNan::new(0f32).unwrap()
485486
})
486487
.euclidean_similarity()
487488
.abs_diff_eq(&(1f32 - 1f32 / 2f32.sqrt()), 1e-5));
488489
assert!((WordSimilarityResult {
489490
word: "test",
490-
similarity: (-1f32).into()
491+
similarity: NotNan::new(-1f32).unwrap(),
491492
})
492493
.euclidean_similarity()
493494
.abs_diff_eq(&0f32, 1e-5));
@@ -513,8 +514,6 @@ mod tests {
513514
let result = result.unwrap();
514515
assert_eq!(10, result.len());
515516

516-
println!("{:?}", result);
517-
518517
for (idx, word_similarity) in result.iter().enumerate() {
519518
assert_eq!(SIMILARITY_ORDER[idx], word_similarity.word)
520519
}
@@ -548,8 +547,6 @@ mod tests {
548547
let result = result.unwrap();
549548
assert_eq!(10, result.len());
550549

551-
println!("{:?}", result);
552-
553550
for (idx, word_similarity) in result.iter().enumerate() {
554551
assert_eq!(SIMILARITY_ORDER_STUTTGART_10[idx], word_similarity.word)
555552
}

0 commit comments

Comments
 (0)