Support Matrix Market symmetry and binsparse fixtures#799
Draft
BenBrock wants to merge 2 commits into
Draft
Conversation
Author
|
@willow-ahrens Can you comment in the MatrixMarket.jl dependency here? Looks like TensorMarket fails to read certain Matrix Market files directly. The rest of the changes are to reading Binsparse files, which I think need to be made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a few updates and modifications to Finch.jl to support the Binsparse files and Matrix Market files used by the (WIP) Binsparse testing framework.
This consists primarily of 1) routing
.mtxfiles toMatrixMarket.jlinstead of TensorMarket, since TensorMarket fails on Matrix Market files; 2) Adding support foriso[...]scalar values; and 3) extending Finch's Binsparse reader to properly handled structured matrices (symmetric, etc.).The rest of this PR summary is generated by Codex. Most of the code changes in this PR are AI-generated and need review (thus it's a draft PR).
The main changes are:
Motivation
The current Finch fileio path had a few gaps that showed up immediately when running the new binsparse parser test framework:
This branch closes those gaps so Finch can participate in the same roundtrip fixture tests as the other parser implementations.
Tests
Added coverage for:
Validated with: