remove Hash Table from FinchAssembly#541
Conversation
Merging this PR will degrade performance by 13.73%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | test_ops_binary[interpret_galley-add] |
787 ms | 912.7 ms | -13.78% |
| ❌ | WallTime | test_ops_binary[interpret_galley-multiply] |
786.2 ms | 911.4 ms | -13.74% |
| ❌ | WallTime | test_ops_reduction[interpret_galley-sum] |
419.5 ms | 485.9 ms | -13.67% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing wma/rm_hash (06126ad) with main (64775fa)
kylebd99
left a comment
There was a problem hiding this comment.
This looks good to me! I love a PR that removes nodes from a language.
|
@willow-ahrens @hameerabbasi codspeed seems a bit sensitive/jittery on wallclock mode, would it make sense to shift the tolerance to like 25% for the moment? Edit: Ahh, nevermind, I thought it was blocking PRs. This is fine. |
|
Yes, lets.
…________________________________
From: Kyle Deeds ***@***.***>
Sent: Tuesday, 30 June 2026 18:26:13
To: finch-tensor/finch-tensor-lite ***@***.***>
Cc: Willow Ahrens ***@***.***>; Mention ***@***.***>
Subject: Re: [finch-tensor/finch-tensor-lite] remove Hash Table from FinchAssembly (PR #541)
[https://avatars.githubusercontent.com/u/27299171?s=20&v=4]kylebd99 left a comment (finch-tensor/finch-tensor-lite#541)<#541 (comment)>
@willow-ahrens<https://github.com/willow-ahrens> @hameerabbasi<https://github.com/hameerabbasi> codspeed seems a bit sensitive/jittery on wallclock mode, would it make sense to shift the tolerance to like 25% for the moment?
—
Reply to this email directly, view it on GitHub<#541?email_source=notifications&email_token=ABMAYDZSPGIBNQG7TAMVHBT5CQ5ALA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBUHA2DCMJRGA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4848411105>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMAYD2P4CUJOFC2VGJISJD5CQ5ALAVCNFSNUABFKJSXA33TNF2G64TZHM4TOMRXGQ3DANRXHNEXG43VMU5TINZXHE4DCNZXGA22C5QC>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
In the future, we will build hash tables out of FinchAssembly. fixes #406