Skip to content

remove Hash Table from FinchAssembly#541

Open
willow-ahrens wants to merge 3 commits into
mainfrom
wma/rm_hash
Open

remove Hash Table from FinchAssembly#541
willow-ahrens wants to merge 3 commits into
mainfrom
wma/rm_hash

Conversation

@willow-ahrens

Copy link
Copy Markdown
Member

In the future, we will build hash tables out of FinchAssembly. fixes #406

@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.73%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 3 regressed benchmarks
✅ 29 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_ops_binary[interpret_galley-add] 787 ms 912.7 ms -13.78%
WallTime test_ops_binary[interpret_galley-multiply] 786.2 ms 911.4 ms -13.74%
WallTime test_ops_reduction[interpret_galley-sum] 419.5 ms 485.9 ms -13.67%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing wma/rm_hash (06126ad) with main (64775fa)

Open in CodSpeed

@kylebd99 kylebd99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I love a PR that removes nodes from a language.

@kylebd99

kylebd99 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@willow-ahrens @hameerabbasi codspeed seems a bit sensitive/jittery on wallclock mode, would it make sense to shift the tolerance to like 25% for the moment?

Edit: Ahh, nevermind, I thought it was blocking PRs. This is fine.

@willow-ahrens

willow-ahrens commented Jun 30, 2026 via email

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Hash tables from finchassembly?

2 participants