service: add optional controlling TTY via tty: stanza

[Ollie-Gutierrez]

Adds a tty:<dev> keyword for run/task/service stanzas to give them a controlling terminal. I decided to separate this from the prepare_tty helper as that prepares some extra stuff for getty/login which I don’t think we need here, though I’d be interested what you think regarding that. I also tried to keep compatibility with log:. Everything works in my tests and I’ll look into writing some short documentation if you’re happy with everything!

I based this on a poc by @aanderse, which initially just reused prepare_tty. This also addresses finix-community/finix#53.

[troglobit]

Some minor comments only, other than that it looks good! 💪 Looking forward to getting this merged, with docs 😊

[Ollie-Gutierrez]

I've addressed both your comments, and also added some documentation and a section on the man page. I put the docs in tty.md, but happy to move it elsewhere if you'd prefer or just make it inline. Thankyou so much for your help too!

[aanderse]

can you please update the luks example from https://finit-project.github.io/switchroot/?h=switch#example-initramfs-finitconf?

[Ollie-Gutierrez]

Done, can't believe I forgot that considering it's the main reason for the pr

[troglobit]

Very nice work on this! As a final touch, please squash the code and doc commits (so we get one for code and one for docs) then we can merge! 😃

[Ollie-Gutierrez]

Apologies for the wait, all done now 👍

[troglobit]

Brilliant, nice work!

[troglobit]

Apologies for the wait, all done now 👍

No worries at all, thanks for hanging in there!

[aanderse]

thanks everyone, greatly appreciated!

---

btw @troglobit ... does this put us at enough changes to justify a new release?

[troglobit]

btw @troglobit ... does this put us at enough changes to justify a new release?

I think so! I'll start preparing and doing some release testing on our systems over the next couple of days.