Skip to content

fix: use node instead of npx in CLI tests to prevent flaky failures#1550

Merged
jescalada merged 2 commits into
finos:mainfrom
fabiovincenzi:fix/windows-cli-test-flaky
May 27, 2026
Merged

fix: use node instead of npx in CLI tests to prevent flaky failures#1550
jescalada merged 2 commits into
finos:mainfrom
fabiovincenzi:fix/windows-cli-test-flaky

Conversation

@fabiovincenzi

@fabiovincenzi fabiovincenzi commented May 27, 2026

Copy link
Copy Markdown
Contributor

Description

Replace npx git-proxy-cli with node packages/git-proxy-cli/dist/index.js in CLI tests to fix intermittent Windows CI failures caused by npx subprocess crashes

Related Issue

Resolves #1549

@fabiovincenzi fabiovincenzi requested a review from a team as a code owner May 27, 2026 08:39
@netlify

netlify Bot commented May 27, 2026

Copy link
Copy Markdown

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 1437c76
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a16ae0fd264f600082bae32

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.65%. Comparing base (1602e54) to head (1437c76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1550   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files          69       69           
  Lines        5690     5690           
  Branches      985      985           
=======================================
  Hits         5158     5158           
  Misses        514      514           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiovincenzi LGTM, thanks for this! I just updated the linked issue which was previously pointing to #1539.

@jescalada jescalada merged commit ffd6937 into finos:main May 27, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI tests are flaky on Windows C

2 participants