Skip to content

Support Agent CommonJWT Authentication #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
symphony-enrico merged 4 commits into from
Jan 23, 2026
+42 −19
Merged

Support Agent CommonJWT Authentication #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4d34d4
Support Agent CommonJWT Authentication
symphony-enrico Jan 20, 2026
f67f802
Revert "Support Agent CommonJWT Authentication"
symphony-enrico Jan 23, 2026
2909627
Support Agent CommonJWT Authentication
symphony-enrico Jan 23, 2026
b64773d
Update BdkCoreConfig.java
symphony-enrico Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions symphony-bdk-core/src/main/java/com/symphony/bdk/core/ServiceFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,18 @@ public ServiceFactory(ApiClientFactory apiClientFactory, AuthSession authSession
+ " please set commonJwt.enabled to false.");
} else {
final OAuthSession oAuthSession = new OAuthSession(authSession);

this.podClient.getAuthentications().put(BEARER_AUTH, new OAuthentication(oAuthSession::getBearerToken));
this.podClient.addEnforcedAuthenticationScheme(BEARER_AUTH);

this.agentClient.getAuthentications().put(BEARER_AUTH, new OAuthentication(oAuthSession::getBearerToken));
this.agentClient.addEnforcedAuthenticationScheme(BEARER_AUTH);

this.datafeedAgentClient.getAuthentications().put(BEARER_AUTH, new OAuthentication(oAuthSession::getBearerToken));
this.datafeedAgentClient.addEnforcedAuthenticationScheme(BEARER_AUTH);

this.datahoseAgentClient.getAuthentications().put(BEARER_AUTH, new OAuthentication(oAuthSession::getBearerToken));
this.datahoseAgentClient.addEnforcedAuthenticationScheme(BEARER_AUTH);
}
}
}
Expand Down
51 changes: 32 additions & 19 deletions ...-core-spring-boot-starter/src/main/java/com/symphony/bdk/spring/config/BdkCoreConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

import com.symphony.bdk.core.auth.AuthSession;
import com.symphony.bdk.core.auth.AuthenticatorFactory;
import com.symphony.bdk.core.auth.impl.AuthenticatorFactoryImpl;
import com.symphony.bdk.core.auth.ExtensionAppTokensRepository;
import com.symphony.bdk.core.auth.impl.OAuthSession;
import com.symphony.bdk.core.auth.impl.OAuthentication;
import com.symphony.bdk.core.auth.exception.AuthInitializationException;
import com.symphony.bdk.core.auth.exception.AuthUnauthorizedException;
import com.symphony.bdk.core.auth.impl.AuthenticatorFactoryImpl;
import com.symphony.bdk.core.auth.impl.InMemoryTokensRepository;
import com.symphony.bdk.core.auth.impl.OAuthSession;
import com.symphony.bdk.core.auth.impl.OAuthentication;
import com.symphony.bdk.core.client.ApiClientFactory;
import com.symphony.bdk.core.config.model.BdkConfig;
import com.symphony.bdk.http.api.ApiClient;
Expand Down Expand Up @@ -41,33 +41,33 @@ public ApiClientFactory apiClientFactory(SymphonyBdkCoreProperties properties) {
}

@Bean(name = "agentApiClient")
public ApiClient agentApiClient(ApiClientFactory apiClientFactory) {
return apiClientFactory.getAgentClient();
public ApiClient agentApiClient(ApiClientFactory apiClientFactory, Optional<AuthSession> botSession,
BdkConfig config) {
ApiClient client = apiClientFactory.getAgentClient();
addCommonJwtConfig(client, botSession, config);
return client;
}

@Bean(name = "datafeedAgentApiClient")
public ApiClient datafeedAgentApiClient(ApiClientFactory apiClientFactory) {
return apiClientFactory.getDatafeedAgentClient();
public ApiClient datafeedAgentApiClient(ApiClientFactory apiClientFactory, Optional<AuthSession> botSession,
BdkConfig config) {
ApiClient client = apiClientFactory.getDatafeedAgentClient();
addCommonJwtConfig(client, botSession, config);
return client;
}

@Bean(name = "datahoseAgentApiClient")
public ApiClient datahoseAgentApiClient(ApiClientFactory apiClientFactory) {
return apiClientFactory.getDatahoseAgentClient();
public ApiClient datahoseAgentApiClient(ApiClientFactory apiClientFactory, Optional<AuthSession> botSession,
BdkConfig config) {
ApiClient client = apiClientFactory.getDatahoseAgentClient();
addCommonJwtConfig(client, botSession, config);
return client;
}

@Bean(name = "podApiClient")
public ApiClient podApiClient(ApiClientFactory apiClientFactory, Optional<AuthSession> botSession, BdkConfig config) {
ApiClient client = apiClientFactory.getPodClient();
if (config.isCommonJwtEnabled()) {
if (config.isOboConfigured()) {
throw new UnsupportedOperationException(
"Common JWT feature is not available yet in OBO mode, please set commonJwt.enabled to false.");
} else if (botSession.isPresent()) {
final OAuthSession oAuthSession = new OAuthSession(botSession.get());
client.getAuthentications().put(BEARER_AUTH, new OAuthentication(oAuthSession::getBearerToken));
client.addEnforcedAuthenticationScheme(BEARER_AUTH);
}
}
addCommonJwtConfig(client, botSession, config);
return client;
}

Expand Down Expand Up @@ -122,4 +122,17 @@ public AuthSession botSession(AuthenticatorFactory authenticatorFactory) {
throw new BeanInitializationException("Unable to authenticate bot", e);
}
}

private void addCommonJwtConfig(ApiClient client, Optional<AuthSession> botSession, BdkConfig config) {
if (config.isCommonJwtEnabled()) {
if (config.isOboConfigured()) {
throw new UnsupportedOperationException(
"Common JWT feature is not available yet in OBO mode, please set commonJwt.enabled to false.");
} else if (botSession.isPresent()) {
final OAuthSession oAuthSession = new OAuthSession(botSession.get());
client.getAuthentications().put(BEARER_AUTH, new OAuthentication(oAuthSession::getBearerToken));
client.addEnforcedAuthenticationScheme(BEARER_AUTH);
}
}
}
}
Loading