CAIP-9 extend tooling with ruff formatter(replacing pylint) (#372)

* CAIP-9 add pre commit hook to run linter

* CAIP-9 update ruff config

* CAIP-9 update ruff config

* CAIP-9 update ruff config

* CAIP-9 try adding py file

* CAIP-9 add ruff formatter

* CAIP-9 rename workflow file and update readme

* CAIP-9 remove dependencies

* CAIP-9 update readme

* CAIP-9 rebase from main

* CAIP-9 fix broken tests

* CAIP-9 extend line length

* CAIP-9 fix missing files

Author: broHeryk

.github/workflows/linting.yaml

@@ -0,0 +1,48 @@
+name: Linting
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+
+jobs:
+  ruff:
+    name: Ruff Linter & Formatter
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+
+      - name: Set up Python 3.9
+        uses: actions/setup-python@v4
+        with:
+          python-version: 3.9
+
+      - name: Install Poetry
+        run: pip install poetry
+
+      - name: Cache poetry virtualenv
+        uses: actions/cache@v4
+        with:
+          path: ~/.cache/pypoetry/virtualenvs
+          key: ${{ runner.os }}-poetry-${{ hashFiles('poetry.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-poetry-
+
+      - name: Install dependencies
+        run: poetry install
+
+      - name: Cache ruff
+        uses: actions/cache@v4
+        with:
+          path: .ruff_cache
+          key: ${{ runner.os }}-ruff-${{ github.ref_name }}-${{ hashFiles('poetry.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-ruff-main-${{ hashFiles('poetry.lock') }}
+
+      - name: Run ruff formatter check
+        run: poetry run ruff format --check .
+
+      - name: Run ruff linter
+        run: poetry run ruff check .

.github/workflows/pylint.yaml

@@ -0,0 +1,7 @@
+repos:
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.12.8
+    hooks:
+      - id: ruff-format
+      - id: ruff-check
+        args: [ --fix ]

.pre-commit-config.yaml

@@ -23,9 +23,23 @@ Symphony BDK for Python provides tools for building bots and integrating with Sy
 - Install dependencies: `poetry install`
 - Build the package: `poetry build`
 - Run tests: `poetry run pytest`
-- Perform a pylint scan locally: `poetry run pylint <module_name>`
+- Perform a lint scan locally: `poetry run ruff check .`
+- Format code locally: `poetry run ruff format .`
 - Generate documentation locally: `cd docsrc && make html`
 
+### Setting Up Git Hooks
+This project uses `pre-commit` with `ruff` to automatically format and lint code. This is the recommended setup for contributors to ensure code style consistency.
+
+1. **Install development dependencies** (this will also install `pre--commit` and `ruff`):
+   ```bash
+   poetry install
+   ```
+2. **Install the git hooks**:
+   ```bash
+   poetry run pre-commit install
+   ```
+Now, `ruff` will automatically run on every commit, formatting your code and checking for linting errors.
+
 ### Verification
 Verify the successful installation by running any of the following commands:
 ```

README.md

@@ -26,7 +26,9 @@ async def on_activity(self, context: CommandContext):
         await self._messages.send_message(context.stream_id, "<messageML>Hello, World!</messageML>")
 
 
-logging.config.fileConfig(Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False)
+logging.config.fileConfig(
+    Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False
+)
 
 try:
     logging.info("Running activity example...")

examples/activities/command_activity.py

@@ -32,21 +32,27 @@ def __init__(self, messages: MessageService):
         self.messages = messages
 
     def matches(self, context: FormReplyContext) -> bool:
-        return context.form_id == "gif-category-form" \
-               and context.get_form_value("action") == "submit" \
-               and context.get_form_value("category")
+        return (
+            context.form_id == "gif-category-form"
+            and context.get_form_value("action") == "submit"
+            and context.get_form_value("category")
+        )
 
     async def on_activity(self, context: FormReplyContext):
         category = context.get_form_value("category")
-        await self.messages.send_message(context.source_event.stream.stream_id,
-                                         "<messageML> You just submitted this category: " + category + "</messageML>")
+        await self.messages.send_message(
+            context.source_event.stream.stream_id,
+            "<messageML> You just submitted this category: " + category + "</messageML>",
+        )
 
 
 def load_gif_elements_form():
     return (Path(__file__).parent.parent / "resources/gif.mml.xml").read_text(encoding="utf-8")
 
 
-logging.config.fileConfig(Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False)
+logging.config.fileConfig(
+    Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False
+)
 
 try:
     logging.info("Running activity example...")

examples/activities/form_activity.py

@@ -22,7 +22,9 @@ async def on_hello(context: CommandContext):
         await bdk.datafeed().start()
 
 
-logging.config.fileConfig(Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False)
+logging.config.fileConfig(
+    Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False
+)
 
 try:
     logging.info("Running activity example...")

examples/activities/slash_command_activity.py

@@ -16,7 +16,9 @@ async def run():
         @activities.slash("/echo {@mention_argument}")
         async def on_echo_mention(context: CommandContext):
             mentioned_user = context.arguments.get_mention("mention_argument")
-            message = f"Mentioned user: {mentioned_user.user_display_name}, id: {mentioned_user.user_id}"
+            message = (
+                f"Mentioned user: {mentioned_user.user_display_name}, id: {mentioned_user.user_id}"
+            )
 
             await messages.send_message(context.stream_id, f"<messageML>{message}</messageML>")
 
@@ -36,7 +38,6 @@ async def on_echo_cashtag(context: CommandContext):
 
         @activities.slash("/echo {first_string_argument} {second_string_argument}")
         async def on_echo_string_arguments(context: CommandContext):
-
             # Get string argument with get_string
             first_string_argument = context.arguments.get_string("first_string_argument")
 
@@ -52,11 +53,12 @@ async def on_echo_string_arguments(context: CommandContext):
         await bdk.datafeed().start()
 
 
-logging.config.fileConfig(Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False)
+logging.config.fileConfig(
+    Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False
+)
 
 try:
     logging.info("Running activity example...")
     asyncio.run(run())
 except KeyboardInterrupt:
     logging.info("Ending activity example")
-

examples/activities/slash_command_with_arguments_activity.py

@@ -2,7 +2,10 @@
 import logging.config
 from pathlib import Path
 
-from symphony.bdk.core.activity.user_joined_room import UserJoinedRoomActivity, UserJoinedRoomContext
+from symphony.bdk.core.activity.user_joined_room import (
+    UserJoinedRoomActivity,
+    UserJoinedRoomContext,
+)
 from symphony.bdk.core.config.loader import BdkConfigLoader
 from symphony.bdk.core.service.message.message_service import MessageService
 from symphony.bdk.core.symphony_bdk import SymphonyBdk
@@ -23,14 +26,17 @@ def matches(self, context: UserJoinedRoomContext) -> bool:
         return True
 
     async def on_activity(self, context: UserJoinedRoomContext):
-        await self._messages.send_message(context.stream_id,
-                                          "<messageML>Welcome to the room</messageML>")
+        await self._messages.send_message(
+            context.stream_id, "<messageML>Welcome to the room</messageML>"
+        )
 
 
-logging.config.fileConfig(Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False)
+logging.config.fileConfig(
+    Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False
+)
 
 try:
     logging.info("Running activity example...")
     asyncio.run(run())
 except KeyboardInterrupt:
-    logging.info("Ending activity example")
+    logging.info("Ending activity example")

examples/activities/user_joined_room_activity.py

@@ -18,6 +18,8 @@ async def run():
         logging.info(await obo_auth_session.session_token)
 
 
-logging.config.fileConfig(Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False)
+logging.config.fileConfig(
+    Path(__file__).parent.parent / "logging.conf", disable_existing_loggers=False
+)
 
 asyncio.run(run())