Fix version in git actions and use customised PyJWT to bypass subject verification#355
Merged
Merged
Conversation
broHeryk
force-pushed
the
feature/fix-jwt-validation
branch
from
fe5a2ec to
a4d1654
Compare
broHeryk
changed the title
yinan-symphony
approved these changes
May 15, 2025
yinan-symphony
changed the title
yinan-symphony
pushed a commit
that referenced
this pull request
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the latest bdk version, I noticed that the validate_sub method for PyJwt package(version 2.10) is incompatible with Symphony JWT token(it has an integer subject value). The error is provided below:
Subject must be a string Validation Error
Verification can be disabled by passing the flag:
PyJWT({"verify_sub": False})
Since the vulnerabilities bot does not allow downgrading PyJWT package, I suggest using this flag in the BDK code(symphony/bdk/core/auth/jwt_helper.py)
Other changes in this PR are related to outdated versions, platforms, and a broken GitHub actions flow.