fix(auth): fixed Google's icon background so it is transparent. For light and dark mode.#438
Closed
flying-wizzy wants to merge 1 commit into
Closed
fix(auth): fixed Google's icon background so it is transparent. For light and dark mode.#438flying-wizzy wants to merge 1 commit into
flying-wizzy wants to merge 1 commit into
Conversation
…utton looks correct in light and dark mode
russellwheatley
changed the title
russellwheatley
changed the title
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Contributor
|
up ? Can we repopen it ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed google_icon.svg white background, so that GoogleSignInButton looks correct in light and dark mode.
I have not spent enough time with the repo to be sure of this, however I believe that directory
firebase_ui_oath_google/assetsandgoogle_icon.svgcan be deleted altogether, because they are not being used. Correct my if I am wrong.Related Issues
fixes #16
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?