Update and rename firestore-counter/POSTINSTALL.md to firestore-count…#2905
Open
filforopen-source wants to merge 397 commits into
Open
Update and rename firestore-counter/POSTINSTALL.md to firestore-count…#2905filforopen-source wants to merge 397 commits into
filforopen-source wants to merge 397 commits into
Conversation
…ase#2364) * feat(firestore-bigquery-changetracker): support non-default db * chore(*): unlink local changetracker * chore(*): unlink local changetracker * chore(*): unlink local changetracker again * chore(*): force change cache in CI * fix(firestore-bigquery-changetracker): make change non-breaking * chore(firestore-bigquery-change-tracker): make test output readable * chore(firestore-bigquery-change-tracker): bump package version
…t db * feat(firestore-bigquery-export): v2 initial migration changes * feat(firestore-bigquery-export): use latest changetracker version * chore: revert removal of fft package * fix: provide default db in config.ts * fix: update snapshot
firebase#2371) * fix(firestore-bigquery-export): fix types passed to syncBigQuery queue * Update firestore-bigquery-export/functions/src/index.ts
Release 17/04/25
…se#2382) * fix(firestore-bigquery-export): correct database region param * fix(firestore-shorten-urls-bitly): fix database region * fix(firestore-shorten-urls-bitly): make db region mutable
Release firestore-bigquery-export and firestore-shorten-urls-bitly extension fixes
Merge pull request firebase#2384 from firebase/next
…ing error when using SendGrid (firebase#2385)
* feat(firestore-send-email): migrate to v2 cloud function * chore(firestore-send-email): format * chore(firestore-send-email): generate readme and fix issue in extension.yaml * fix(firestore-send-email): sourceDirectory * fix(firestore-send-email): correct database being used * fix(firestore-send-email): fixing tests * chore(firestore-send-email): format * chore(firestore-send-email): rid of unnecessary files * fix(firestore-send-email): fixing tests * fix(firestore-send-email): fix extension.yaml * chore(firestore-send-email): generate readme and fix issue in extension.yaml * fix(firestore-send-email): correct database being used * chore(firestore-send-email): rid of unnecessary files * Apply suggestions from code review fix: add defaults to config.ts to make tests run --------- Co-authored-by: Jacob Cable <32874567+cabljac@users.noreply.github.com>
Merge pull request firebase#2389 from firebase/next
Release firestore-bigquery-export
Merge pull request firebase#2399 from firebase/next
firebase#2402) * fix(firestore-send-email): add types and attempt to extract message ID * feat(firestore-send-email): patch nodemailer-sendgrid * test(firestore-send-email): add tests for nodemailer sendgrid patch * feat(firestore-send-email): explicitly handle sendgrid keys * fix(firestore-send-email): better extract message id * feat(firestore-send-email): return sendgrid queue id and message id * chore(firestore-send-email): bump versions etc * test(firestore-send-email): update tests * refactor(firestore-send-email): extract sendgrid transport types * chore(firestore-send-email): restore code comments * chore(firestore-send-email): improve types * chore(firestore-send-email): add extended options type * chore(firestore-send-email): add JSDoc comments * docs(firestore-send-email): update sendgrid docs
…base#2411) * feat(firestore-bigquery-export): add bigquery dataset locations * chore(firestore-bigquery-export): remove duplicate bigquery dataset locations * chore: bump firestore-bigquery-export version * chore: run formatter
* feat(import-script): handle not finding collection * fix(import-script): await runSingleThread * refactor(import-script): extract variable to avoid calculating twice
Release firestore-send-email and firestore-bigquery-export extensions
…ipts chore(firestore-bigquery-export): bump script versions for release
…mplate-docs docs(firestore-send-email): add docs on dynamic SendGrid templates
* fix(firestore-send-email): fix validation logic * docs(firestore-send-email): add jsdoc comments
…date firebase deps
…s and restore version spec
…re-counter Security Audit & Remediation: firestore-counter
…-resize-images Security Audit & Remediation: storage-resize-images
…re-translate-text Security Audit & Remediation: firestore-translate-text
…mit-child-nodes Security Audit & Remediation: rtdb-limit-child-nodes
…re-shorten-urls-bitly Security Audit & Remediation: firestore-shorten-urls-bitly
…re-send-email Security Audit & Remediation: firestore-send-email
…user-data Security Audit & Remediation: delete-user-data
…ean race condition
…re-bigquery-export Security Audit & Remediation: firestore-bigquery-export
…er/INSTALL.md/Phone
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request contains an accidental file rename and deletion of critical post-installation instructions in the POSTINSTALL.md file. The reviewer correctly identified that this change will break the Firebase CLI and Console integration, and requested reverting the rename and restoring the original file structure.
filforopen-source
changed the base branch from
master
to
@invertase/update-bq-docs
Wiz Scan Summary
|
| Scanner | Findings |
|---|---|
 |
17    |
 |
- |
 |
- |
 |
- |
 |
1  |
 |
- |
| Total | 1 |
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er/INSTALL.md/Phone