fix(firestore-counter): repair package-lock for builder npm#2907
Merged
Conversation
Drop unused ts-node@^7 devDep and regenerate lock so npm ci resolves jest-config's optional ts-node peer against the lock. The prior lock was generated with a newer npm than the extensions builder runs (npm 9), which demanded a ts-node@10.9.2 subtree absent from the lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
nextfails uploadingfirestore-counter@0.2.17-rc.0:Root cause
The extensions builder falls back to npm 9 (its
nvm install 22fails: "version v22 is not yet installed"). npm 9'snpm ciauto-resolves jest-config's optional peerts-node: >=9.0.0tots-node@10.9.2and demands that subtree in the lock. The lock (last regenerated with a newer npm) only carried the directts-node@7.0.1and lacked the 10.9.2 tree.Reproduced locally:
npm@9 cifails with the identical error;npm@11 cipasses, which is why it slipped through.Fix
ts-node@^7.0.1. Thets-jestpreset does not use it; sibling extensions (firestore-send-email,storage-resize-images) run the same preset with nots-node.npm@9 install --package-lock-only). Only the ts-node subtree changed;@types/node@22.19.17and all other pins are untouched. A from-scratch regen was avoided because it floats@types/nodeand breakstsc@4.9.Validation
npm ciexit 0 under both npm 9 (builder) and npm 11npm ci-> build (tsc) exit 0controller.emulator.test.tsfails, which needs a running Firestore emulator)