test(firebase_admin_sdk): add tag-based test filtering#279
Open
demolaf wants to merge 8 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces test presets and tagging for Firebase emulators, production, and WIF environments, updating the CI configuration and coverage scripts. It also improves URL validation, refactors input validation in the authentication request handler, and optimizes the signing process to use local credentials when available. Review feedback suggests enhancing email validation by using assertIsEmail for more robust checks and replacing hardcoded request type strings with constants to improve maintainability.
Coverage Report✅ Coverage 75.16% meets 40% threshold Total Coverage: 75.16% Package Breakdown
Minimum threshold: 40% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.