Skip to content

Commit f3bbbb3

Browse files
jonathanedeyjonathanedey
authored
chore: Update test dependencies (#469)
* chore: Update dependencies * fix: github actions status badge * Trigger Integration Tests * fix: revert AspNetCore updates
1 parent 4381737 commit f3bbbb3

7 files changed

Lines changed: 24 additions & 22 deletions

File tree

‎FirebaseAdmin/FirebaseAdmin.IntegrationTests/Auth/GetUsersTest.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public GetUsersTest(GetUsersFixture fixture)
3131
}
3232

3333
[Fact]
34-
public async void VariousIdentifiers()
34+
public async Task VariousIdentifiers()
3535
{
3636
var getUsersResult = await FirebaseAuth.DefaultInstance.GetUsersAsync(
3737
new List<UserIdentifier>()
@@ -56,7 +56,7 @@ public async void VariousIdentifiers()
5656
}
5757

5858
[Fact]
59-
public async void IgnoresNonExistingUsers()
59+
public async Task IgnoresNonExistingUsers()
6060
{
6161
var doesntExistId = new UidIdentifier("uid_that_doesnt_exist");
6262
var getUsersResult = await FirebaseAuth.DefaultInstance.GetUsersAsync(
@@ -79,7 +79,7 @@ public async void IgnoresNonExistingUsers()
7979
}
8080

8181
[Fact]
82-
public async void OnlyNonExistingUsers()
82+
public async Task OnlyNonExistingUsers()
8383
{
8484
var doesntExistId = new UidIdentifier("uid_that_doesnt_exist");
8585
var getUsersResult = await FirebaseAuth.DefaultInstance.GetUsersAsync(
@@ -93,7 +93,7 @@ public async void OnlyNonExistingUsers()
9393
}
9494

9595
[Fact]
96-
public async void DedupsDuplicateUsers()
96+
public async Task DedupsDuplicateUsers()
9797
{
9898
var getUsersResult = await FirebaseAuth.DefaultInstance.GetUsersAsync(
9999
new List<UserIdentifier>()

‎FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<PackageReference Include="Microsoft.AspNetCore.WebUtilities" Version="2.2.0" />
1414
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
1515
<PackageReference Include="System.Text.Json" Version="8.0.5" />
16-
<PackageReference Include="xunit" Version="2.7.0" />
16+
<PackageReference Include="xunit" Version="2.9.3" />
1717
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
1818
<PrivateAssets>all</PrivateAssets>
1919
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

‎FirebaseAdmin/FirebaseAdmin.Tests/Auth/FirebaseAuthTest.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
// limitations under the License.
1414

1515
using System;
16+
using System.Threading.Tasks;
1617
using FirebaseAdmin.Auth.Jwt;
1718
using Google.Apis.Auth.OAuth2;
1819
using Xunit;
@@ -171,7 +172,7 @@ public void ServiceAccountId()
171172
}
172173

173174
[Fact]
174-
public async void InvalidCredential()
175+
public async Task InvalidCredential()
175176
{
176177
var options = new AppOptions
177178
{

‎FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/EmailActionRequestTest.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public class EmailActionRequestTest
9292
};
9393

9494
[Fact]
95-
public async void NoEmail()
95+
public async Task NoEmail()
9696
{
9797
var handler = new MockMessageHandler() { Response = GenerateEmailLinkResponse };
9898
var auth = this.CreateFirebaseAuth(handler);
@@ -115,7 +115,7 @@ await Assert.ThrowsAsync<ArgumentException>(
115115

116116
[Theory]
117117
[MemberData(nameof(InvalidActionCodeSettingsArgs))]
118-
public async void InvalidActionCodeSettings(ActionCodeSettings settings)
118+
public async Task InvalidActionCodeSettings(ActionCodeSettings settings)
119119
{
120120
var handler = new MockMessageHandler() { Response = GenerateEmailLinkResponse };
121121
var auth = this.CreateFirebaseAuth(handler);
@@ -264,7 +264,7 @@ public async Task PasswordResetLinkUnexpectedResponse()
264264
}
265265

266266
[Fact]
267-
public async void SignInWithEmailLinkNoSettings()
267+
public async Task SignInWithEmailLinkNoSettings()
268268
{
269269
var handler = new MockMessageHandler() { Response = GenerateEmailLinkResponse };
270270
var auth = this.CreateFirebaseAuth(handler);

‎FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/FirebaseUserManagerTest.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1302,7 +1302,7 @@ public async Task NullClaims(TestConfig config)
13021302

13031303
[Theory]
13041304
[MemberData(nameof(TestConfigs))]
1305-
public async void ReservedClaims(TestConfig config)
1305+
public async Task ReservedClaims(TestConfig config)
13061306
{
13071307
var handler = new MockMessageHandler();
13081308
var auth = config.CreateAuth(handler);
@@ -1321,7 +1321,7 @@ await Assert.ThrowsAsync<ArgumentException>(
13211321

13221322
[Theory]
13231323
[MemberData(nameof(TestConfigs))]
1324-
public async void UpdateUserNoUid(TestConfig config)
1324+
public async Task UpdateUserNoUid(TestConfig config)
13251325
{
13261326
var handler = new MockMessageHandler();
13271327
var auth = config.CreateAuth(handler);
@@ -1335,7 +1335,7 @@ public async void UpdateUserNoUid(TestConfig config)
13351335

13361336
[Theory]
13371337
[MemberData(nameof(TestConfigs))]
1338-
public async void UpdateUserInvalidUid(TestConfig config)
1338+
public async Task UpdateUserInvalidUid(TestConfig config)
13391339
{
13401340
var handler = new MockMessageHandler();
13411341
var auth = config.CreateAuth(handler);
@@ -1487,7 +1487,7 @@ public async Task UpdateUserShortPassword(TestConfig config)
14871487

14881488
[Theory]
14891489
[MemberData(nameof(TestConfigs))]
1490-
public async void EmptyNameClaims(TestConfig config)
1490+
public async Task EmptyNameClaims(TestConfig config)
14911491
{
14921492
var handler = new MockMessageHandler();
14931493
var auth = config.CreateAuth(handler);
@@ -1502,7 +1502,7 @@ await Assert.ThrowsAsync<ArgumentException>(
15021502

15031503
[Theory]
15041504
[MemberData(nameof(TestConfigs))]
1505-
public async void LargeClaimsOverLimit(TestConfig config)
1505+
public async Task LargeClaimsOverLimit(TestConfig config)
15061506
{
15071507
var handler = new MockMessageHandler();
15081508
var auth = config.CreateAuth(handler);
@@ -1732,7 +1732,7 @@ public async Task RevokeRefreshTokens(TestConfig config)
17321732

17331733
[Theory]
17341734
[MemberData(nameof(TestConfigs))]
1735-
public async void RevokeRefreshTokensNoUid(TestConfig config)
1735+
public async Task RevokeRefreshTokensNoUid(TestConfig config)
17361736
{
17371737
var handler = new MockMessageHandler() { Response = CreateUserResponse };
17381738
var auth = config.CreateAuth(handler);
@@ -1745,7 +1745,7 @@ await Assert.ThrowsAsync<ArgumentException>(
17451745

17461746
[Theory]
17471747
[MemberData(nameof(TestConfigs))]
1748-
public async void RevokeRefreshTokensInvalidUid(TestConfig config)
1748+
public async Task RevokeRefreshTokensInvalidUid(TestConfig config)
17491749
{
17501750
var auth = config.CreateAuth(new MockMessageHandler());
17511751

@@ -1756,7 +1756,7 @@ await Assert.ThrowsAsync<ArgumentException>(
17561756

17571757
[Theory]
17581758
[MemberData(nameof(MainTenantTestConfigs))]
1759-
public async void CreateSessionCookieNoIdToken(TestConfig config)
1759+
public async Task CreateSessionCookieNoIdToken(TestConfig config)
17601760
{
17611761
var handler = new MockMessageHandler() { Response = "{}" };
17621762
var auth = (FirebaseAuth)config.CreateAuth(handler);
@@ -1773,7 +1773,7 @@ await Assert.ThrowsAsync<ArgumentException>(
17731773

17741774
[Theory]
17751775
[MemberData(nameof(MainTenantTestConfigs))]
1776-
public async void CreateSessionCookieNoOptions(TestConfig config)
1776+
public async Task CreateSessionCookieNoOptions(TestConfig config)
17771777
{
17781778
var handler = new MockMessageHandler() { Response = "{}" };
17791779
var auth = (FirebaseAuth)config.CreateAuth(handler);
@@ -1784,7 +1784,7 @@ await Assert.ThrowsAsync<ArgumentNullException>(
17841784

17851785
[Theory]
17861786
[MemberData(nameof(MainTenantTestConfigs))]
1787-
public async void CreateSessionCookieNoExpiresIn(TestConfig config)
1787+
public async Task CreateSessionCookieNoExpiresIn(TestConfig config)
17881788
{
17891789
var handler = new MockMessageHandler() { Response = "{}" };
17901790
var auth = (FirebaseAuth)config.CreateAuth(handler);

‎FirebaseAdmin/FirebaseAdmin.Tests/FirebaseAdmin.Tests.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
<PackageReference Include="Google.Apis.Auth" Version="1.68.0" />
1919
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
2020
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
21-
<PackageReference Include="System.Linq.Async" Version="6.0.1" />
22-
<PackageReference Include="xunit" Version="2.7.0" />
21+
<PackageReference Include="System.Linq.Async" Version="6.0.3" />
22+
<PackageReference Include="xunit" Version="2.9.3" />
2323
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
2424
<PrivateAssets>all</PrivateAssets>
2525
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

‎README.md‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
[![Build Status](https://github.com/firebase/firebase-admin-dotnet/workflows/Continuous%20Integration/badge.svg)](https://github.com/firebase/firebase-admin-dotnet/actions)
1+
[![Continuous Integration](https://github.com/firebase/firebase-admin-dotnet/actions/workflows/ci.yml/badge.svg)](https://github.com/firebase/firebase-admin-dotnet/actions/workflows/ci.yml)
2+
[![Nightly Builds](https://github.com/firebase/firebase-admin-dotnet/actions/workflows/nightly.yml/badge.svg)](https://github.com/firebase/firebase-admin-dotnet/actions/workflows/nightly.yml)
23

34
# Firebase Admin .NET SDK
45

0 commit comments

Comments
 (0)