chore(ci): address security findings flagged by zizmor#766
Open
morganchen12 wants to merge 34 commits into
Open
chore(ci): address security findings flagged by zizmor#766morganchen12 wants to merge 34 commits into
morganchen12 wants to merge 34 commits into
Conversation
- Release 4.12.0
* chore: Added and `AGENTS.md` file to instruct AI agents how to interact with this repository (#710) * fix(auth): Fixed auth error code parsing (#712) * fix(auth): Fixed auth error code parsing * fix(auth): Fixed test to use error message prefix * chore: update copyright headers from Google Inc. to Google LLC (#713) * chore: Update github actions workflows and integration test resources (#740) * chore: Pinned github actions to a full-length commit SHA * chore: Update integration test resources * chore: Added environment label to release action * Trigger integration tests * feat(firestore): Added Firestore Multi Database Support (#733) * feat(firestore): Add Firestore Multi Database Support * fix: Address gemini review * fix: gemini review * fix: Update name from API review * fix: Address review comments * chore: Fix CONTRIBUTING.md typo Co-authored-by: Lahiru Maramba <llahiru@gmail.com> --------- Co-authored-by: Lahiru Maramba <llahiru@gmail.com> * feat(auth): Add `QueryUsers` API (#727) This change implements the accounts:query functionality, providing a new QueryUsers method that allows searching for users with filters and sorting options. RELEASE_NOTE: Added QueryUsers() API to support querying user accounts with filters, sorting, and pagination. * Update the release actions process (#741) This PR refactors the release automation to improve security by removing the direct merge from the workflow. * [chore] Release 4.19.0 (#742) * Revert "[chore] Release 4.19.0 (#742)" (#744) This reverts commit 3a86709. * chore: Update Release Workflows for Push triggers (#745) * chore: Update release actions to run on Release env * Trigger CI * update the actions * update the base_ref * remove fetch-depth to prevent conflicts * [chore] Release 4.19.0 Take 2 (#746) --------- Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com> Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
- Applied `persist-credentials: false` to checkout steps to prevent credential leakage. - Added explicit workflow-level `contents: read` permissions. - Added explicit job-level permissions to `publish_release` in `release.yml`.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
lahirumaramba
approved these changes
Jun 30, 2026
jonathanedey
reviewed
Jul 6, 2026
jonathanedey
left a comment
jonathanedey
left a comment
Contributor
There was a problem hiding this comment.
Thinking this should be staged against dev instead.
@lahirumaramba I just noticed that the dev and master versions of the release workflows are slightly out of sync since I thought we removed the tag_release workflow and pr creation permissions in #751. I think aa29809 may have overwritten these.
Author
|
Synced this PR with dev: dev...mc/zizmor Does this diff look correct? |
Member
|
Ah, good catch @jonathanedey. Thanks! I changed the base to |
lahirumaramba
requested changes
Jul 7, 2026
lahirumaramba
left a comment
lahirumaramba
left a comment
Member
There was a problem hiding this comment.
Let's hold off on this until we figure out the workflow issues. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persist-credentials: falseto checkout steps to prevent credential leakage.contents: readpermissions.publish_releaseinrelease.yml.