feat(error): Decouple public error codes, modularize error files, and enable declaration merging (#3127)

* chore(auth): Refactor auth error logic

* chore(installations): Refactor installations and instance id error logic

* chore(fcm): Refactor fcm error logic

* fix(auth): Fix auth error mapping that were not copied correctly

* fix(auth): Fixed `INVALID_SERVICE_ACCOUNT` to map to a valid client code

* chore(pm): Refactor project management error logic

* chore: Fix license year for new files

* chore(rtdb): Refactor rtdb error logic

* chore(fs): Refactor firestore error logic

* chore(app): Refactor app error logic

* chore(security-rules): Refactor security rules error logic

* chore(app-check): Refactor app check error logic

* chore(remote-config): Refactor remote config error logic

* chore(functions): Refactor functions error logic

* chore(extensions): Refactor extensions error logic

* chore(fdc): Refactor data connect error logic

* chore(ml): Refactor ml error logic

* chore(eventarc): Refactor eventarc error logic

* chore(fpnv): Refactor pnv error logic

* fix: address gemini review

* fix: Use Declaration Merging to expose error code constant mapping along side error code type

* fix: Address gemini review

* chore: Remove extra whitespace

Author: jonathanedey

.eslintrc.js

@@ -71,6 +71,15 @@ module.exports = {
         "selector": "variable",
         "format": ["camelCase", "UPPER_CASE"]
       },
+      {
+        "selector": "variable",
+        "modifiers": ["const"],
+        "format": ["PascalCase", "camelCase", "UPPER_CASE"],
+        "filter": {
+          "regex": "ErrorCode$", // Matches only if it ends exactly with ErrorCode
+          "match": true,
+        },
+      },
       {
         "selector": "parameter",
         "format": ["camelCase"],

etc/firebase-admin.app-check.api.md

@@ -17,7 +17,20 @@ export class AppCheck {
 }
 
 // @public
-export type AppCheckErrorCode = 'aborted' | 'invalid-argument' | 'invalid-credential' | 'internal-error' | 'permission-denied' | 'unauthenticated' | 'not-found' | 'app-check-token-expired' | 'unknown-error';
+export const AppCheckErrorCode: {
+    readonly ABORTED: "aborted";
+    readonly INVALID_ARGUMENT: "invalid-argument";
+    readonly INVALID_CREDENTIAL: "invalid-credential";
+    readonly INTERNAL: "internal-error";
+    readonly PERMISSION_DENIED: "permission-denied";
+    readonly UNAUTHENTICATED: "unauthenticated";
+    readonly NOT_FOUND: "not-found";
+    readonly APP_CHECK_TOKEN_EXPIRED: "app-check-token-expired";
+    readonly UNKNOWN: "unknown-error";
+};
+
+// @public
+export type AppCheckErrorCode = typeof AppCheckErrorCode[keyof typeof AppCheckErrorCode];
 
 // @public
 export interface AppCheckToken {

etc/firebase-admin.app.api.md

@@ -13,30 +13,22 @@ export interface App {
 }
 
 // @public
-export class AppErrorCodes {
-    // (undocumented)
-    static APP_DELETED: string;
-    // (undocumented)
-    static DUPLICATE_APP: string;
-    // (undocumented)
-    static INTERNAL_ERROR: string;
-    // (undocumented)
-    static INVALID_APP_NAME: string;
-    // (undocumented)
-    static INVALID_APP_OPTIONS: string;
-    // (undocumented)
-    static INVALID_ARGUMENT: string;
-    // (undocumented)
-    static INVALID_CREDENTIAL: string;
-    // (undocumented)
-    static NETWORK_ERROR: string;
-    // (undocumented)
-    static NETWORK_TIMEOUT: string;
-    // (undocumented)
-    static NO_APP: string;
-    // (undocumented)
-    static UNABLE_TO_PARSE_RESPONSE: string;
-}
+export const AppErrorCode: {
+    readonly APP_DELETED: "app-deleted";
+    readonly DUPLICATE_APP: "duplicate-app";
+    readonly INVALID_ARGUMENT: "invalid-argument";
+    readonly INTERNAL_ERROR: "internal-error";
+    readonly INVALID_APP_NAME: "invalid-app-name";
+    readonly INVALID_APP_OPTIONS: "invalid-app-options";
+    readonly INVALID_CREDENTIAL: "invalid-credential";
+    readonly NETWORK_ERROR: "network-error";
+    readonly NETWORK_TIMEOUT: "network-timeout";
+    readonly NO_APP: "no-app";
+    readonly UNABLE_TO_PARSE_RESPONSE: "unable-to-parse-response";
+};
+
+// @public
+export type AppErrorCode = typeof AppErrorCode[keyof typeof AppErrorCode];
 
 // @public
 export function applicationDefault(httpAgent?: Agent): Credential;