Skip to content

Commit 6f5d65b

Browse files
authored
test(firestore): run fixed nested fields tests on prod (#7994)
The breaking change rolled out to prod
1 parent 6791661 commit 6f5d65b

1 file changed

Lines changed: 17 additions & 38 deletions

File tree

  • firebase-firestore/src/androidTest/java/com/google/firebase/firestore

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/PipelineTest.java

Lines changed: 17 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1781,30 +1781,20 @@ public void testNestedFields() {
17811781
Map<String, Object> hitchhikerResult;
17821782
Map<String, Object> duneResult;
17831783

1784-
switch (IntegrationTestUtil.getTargetBackend()) {
1785-
case NIGHTLY:
1786-
hitchhikerResult =
1787-
mapOfEntries(
1788-
entry("title", "The Hitchhiker's Guide to the Galaxy"),
1789-
entry("awards", ImmutableMap.of("hugo", true)));
1790-
duneResult =
1791-
mapOfEntries(entry("title", "Dune"), entry("awards", ImmutableMap.of("hugo", true)));
1792-
break;
1793-
default:
1794-
hitchhikerResult =
1795-
mapOfEntries(
1796-
entry("title", "The Hitchhiker's Guide to the Galaxy"), entry("awards.hugo", true));
1797-
duneResult = mapOfEntries(entry("title", "Dune"), entry("awards.hugo", true));
1798-
break;
1799-
}
1784+
hitchhikerResult =
1785+
mapOfEntries(
1786+
entry("title", "The Hitchhiker's Guide to the Galaxy"),
1787+
entry("awards", ImmutableMap.of("hugo", true)));
1788+
duneResult =
1789+
mapOfEntries(entry("title", "Dune"), entry("awards", ImmutableMap.of("hugo", true)));
18001790

18011791
assertThat(waitFor(execute).getResults())
18021792
.comparingElementsUsing(DATA_CORRESPONDENCE)
18031793
.containsExactly(hitchhikerResult, duneResult);
18041794
}
18051795

18061796
@Test
1807-
public void testMapGetWithFieldNameIncludingNotation() {
1797+
public void testMapGetWithFieldNameIncludingDotNotation() {
18081798
Task<Pipeline.Snapshot> execute =
18091799
firestore
18101800
.pipeline()
@@ -1819,27 +1809,16 @@ public void testMapGetWithFieldNameIncludingNotation() {
18191809

18201810
Map<String, Object> hitchhikerResult;
18211811
Map<String, Object> duneResult;
1822-
1823-
switch (IntegrationTestUtil.getTargetBackend()) {
1824-
case NIGHTLY:
1825-
hitchhikerResult =
1826-
mapOfEntries(
1827-
entry("title", "The Hitchhiker's Guide to the Galaxy"),
1828-
entry("nestedField", ImmutableMap.of("level", ImmutableMap.of())),
1829-
entry("nested", true));
1830-
duneResult =
1831-
mapOfEntries(
1832-
entry("title", "Dune"),
1833-
entry("nestedField", ImmutableMap.of("level", ImmutableMap.of())),
1834-
entry("nested", null));
1835-
break;
1836-
default:
1837-
hitchhikerResult =
1838-
mapOfEntries(
1839-
entry("title", "The Hitchhiker's Guide to the Galaxy"), entry("nested", true));
1840-
duneResult = mapOfEntries(entry("title", "Dune"));
1841-
break;
1842-
}
1812+
hitchhikerResult =
1813+
mapOfEntries(
1814+
entry("title", "The Hitchhiker's Guide to the Galaxy"),
1815+
entry("nestedField", ImmutableMap.of("level", ImmutableMap.of())),
1816+
entry("nested", true));
1817+
duneResult =
1818+
mapOfEntries(
1819+
entry("title", "Dune"),
1820+
entry("nestedField", ImmutableMap.of("level", ImmutableMap.of())),
1821+
entry("nested", null));
18431822

18441823
assertThat(waitFor(execute).getResults())
18451824
.comparingElementsUsing(DATA_CORRESPONDENCE)

0 commit comments

Comments
 (0)