Skip to content

Fix fidchangelistener behavior#8193

Open
eldhosembabu wants to merge 1 commit into
mainfrom
emb/fis-fidchangelistener
Open

Fix fidchangelistener behavior#8193
eldhosembabu wants to merge 1 commit into
mainfrom
emb/fis-fidchangelistener

Conversation

@eldhosembabu
Copy link
Copy Markdown
Contributor

Fixing fidchangelistener behavior to get invoked for new fid creations as well

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@eldhosembabu eldhosembabu requested a review from Doris-Ge May 20, 2026 19:43
@google-oss-bot
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

// Update FidListener if a fid has changed.
updateFidListener(prefs, updatedPrefs);
// Update FidListener if a fid is new or has changed.
if (isNewFID
Copy link
Copy Markdown

@Doris-Ge Doris-Ge May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It may be more readable to clearly define what means a new FID, e.g.:

boolean isNewFidRegistered(PersistedInstallationEntry prefs, PersistedInstallationEntry updatedPrefs) {
   if (!TextUtils.equals(
            prefs.getFirebaseInstallationId(), updatedPrefs.getFirebaseInstallationId()) {
       return true;
   }
   if (!prefs.isRegistered() && updatedPrefs.isRegistered()) {
       return true;
   }
   return false;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants