Skip to content

dataconnect(ci): move firebase-tools version out of the yml workflow files#8197

Merged
dconeybe merged 1 commit into
mainfrom
dconeybe/dataconnect/FirebaseToolsOutOfDataconnectYml
May 21, 2026
Merged

dataconnect(ci): move firebase-tools version out of the yml workflow files#8197
dconeybe merged 1 commit into
mainfrom
dconeybe/dataconnect/FirebaseToolsOutOfDataconnectYml

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

This PR moves the firebase-tools version used in github actions workflows into a new file: firebase-dataconnect/ci/firebase-tools-version.txt. The github actions workflow YML files were changed to read the version from this file instead of hardcoding it.

This has two major benefits:

  1. The version is specified once, instead of being copy/pasted into various locations.
  2. Changing the firebase-tools version no longer triggers workflows for every Firebase product but, rather, only dataconnect.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe dconeybe requested a review from stephenarosaj May 21, 2026 20:58
Copy link
Copy Markdown

@stephenarosaj stephenarosaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit f343cd9 into main May 21, 2026
192 of 198 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/FirebaseToolsOutOfDataconnectYml branch May 21, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants