Add reCAPTCHA site key support to FirebaseOptions#8216
Conversation
Added the reCAPTCHA site key field to FirebaseOptions and its builder to allow configuration of reCAPTCHA within Firebase projects. Additionally, added a lint baseline file to the firebase-common module to manage existing lint issues.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for a recaptchaSiteKey in FirebaseOptions and configures a lint baseline for the firebase-common module. Two issues were identified in the review: a compilation error in FirebaseOptionsTest.java due to an incomplete builder call (.set), and an incorrect, copy-pasted Javadoc comment for getRecaptchaSiteKey() in FirebaseOptions.java.
|
The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
1 similar comment
|
The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Since it's a new feature, minor version bump is the right call
3 participants
Added the reCAPTCHA site key field to FirebaseOptions and its builder to allow configuration of reCAPTCHA within Firebase projects. Additionally, added a lint baseline file to the firebase-common module to manage existing lint issues.