feat(firestore): 16MB docs support#8219
Conversation
WIP Adds support for 16MB docs in Firestore. Changes: - Increases the gRPC message receive size limit from 4MB to 17MB (16MB doc + overhead). - Implements a workaround for the `CursorWindow` 2MB row read limit for reading large docs from local storage. If a row's content is larger than 1MB, executes a seperate query that reads the content in chunks using `SUBSTR` with a chunk size smaller than the row read limit. This is a slow operation for 16MB docs, taking ~200ms in my testing on the local emulator. - Debug logs are now truncated if they exceed 128KB. Formatting proto responses with large documents to strings consumed a huge amount of memory. In one extreme case, formatting a response containing a doc with a field containing 16MB of emojis caused an OOM on emulators. - Adds tests explicitly for large documents.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
2 participants
WIP
Adds support for 16MB docs in Firestore.
Changes:
CursorWindow2MB row read limit for reading large docs from local storage. If a row's content is larger than 1MB, executes a seperate query that reads the content in chunks usingSUBSTRwith a chunk size smaller than the row read limit. This is a slow operation for 16MB docs, taking ~200ms in my testing on the local emulator.