[AppCheck] Recaptcha: use site key from FirebaseOptions#8221
Conversation
Removed the requirement to provide the site key manually during instantiation of RecaptchaEnterpriseAppCheckProviderFactory. The factory now retrieves the site key directly from FirebaseOptions via the FirebaseApp instance provided during the create method.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors RecaptchaEnterpriseAppCheckProviderFactory to remove the siteKey parameter from its constructor and getInstance() method, instead retrieving it dynamically from FirebaseApp options during provider creation. Corresponding updates were made to the API definition, gradle dependencies, and unit tests. A review comment points out that caching the provider instance variable in the factory is now redundant and introduces a potential state-sharing bug in multi-app environments, suggesting that the factory should be made completely stateless.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
2 participants
Removed the requirement to provide the site key manually during instantiation of
RecaptchaEnterpriseAppCheckProviderFactory. The factory now retrieves the site key directly fromFirebaseOptionsvia theFirebaseAppinstance provided during the create method.