[FR] Allow custom attributes on built-in traces (#6664)

[jrodiz]

[FR] Allow custom attributes on built-in traces (#6664)

#6664.

FirebasePerformance already exposes putAttribute / removeAttribute / getAttribute / getAttributes as public Java methods (currently @hide in the Javadocs), backed by a ConcurrentHashMap. TransportManager.setApplicationInfoAndBuild (firebase-perf/src/main/java/com/google/firebase/perf/transport/TransportManager.java:507-512) calls putAllCustomAttributes(getGlobalCustomAttributes()) on ApplicationInfo for every TraceMetric and NetworkRequestMetric, so any global attributes set through that API already ride along on built-in traces and network requests.

This PR adds a unit test that pins down that behavior so the hidden API can be recommended to customers (per discussion with ACore) while the formal public-API review is scheduled separately.

Changes

• TransportManagerTest.java — New unit test logBuiltInTraces_globalCustomAttributesAreAdded covering three paths:
  • App-start trace (_as) → asserts a global attribute appears on ApplicationInfo.custom_attributes.
  • Screen trace (_st_MainActivity) → asserts a second global attribute appears on ApplicationInfo.custom_attributes.
  • Network request → asserts the global attribute appears on ApplicationInfo.custom_attributes.

Usage (today, via the hidden API)

// In Application.onCreate() — set once, applies to all built-in and custom traces
// and to all network requests
FirebasePerformance.getInstance().putAttribute("build_type", "debug");
FirebasePerformance.getInstance().putAttribute("user_tier", "premium");

These attributes appear on _app_start, _app_in_foreground, _app_in_background, screen traces (_st_*), network requests, and all custom traces — at the ApplicationInfo.custom_attributes level — via the existing TransportManager logic.

The methods above are still @hide and the surface is subject to change without notice until the formal API review lands.

Notes

• Attribute limit: the global pool is validated at MAX_TRACE_CUSTOM_ATTRIBUTES (5) by FirebasePerformance.putAttribute's existing checkAttribute() call.
• Thread safety: mCustomAttributes is a ConcurrentHashMap; getAttributes() returns a defensive copy.
• Timing for _app_start: global attributes must be set before the trace is built (e.g., in Application.onCreate()).
• Follow-up (out of scope for this PR): formal API review must document/verify behavior with internal _-prefixed keys and update https://firebase.google.com/docs/perf-mon/attributes?platform=android#collecting-user-data before the four methods can be exposed publicly.

Verification

./gradlew :firebase-perf:test

All tests pass locally.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.