[Infra] Add Firebase automated checks and pre-commit hook#8419
Conversation
Introduced firebase_checks.py to automatically run Gradle tasks (sApp and generateApiTxtFile) for modified subprojects, excluding test applications and resource-only changes. Added setup_hooks.sh to install a Git pre-commit hook that enforces these checks and aborts commits if they result in uncommitted file changes.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a Python script tools/firebase_checks.py to detect modified subprojects and run relevant Gradle tasks, alongside a shell script tools/setup_hooks.sh to install a Git pre-commit hook executing these checks. The review feedback highlights two critical issues: first, the unquoted heredoc delimiter in the setup script causes variables to evaluate at installation time rather than execution time; second, the parsing of git status --porcelain -z in the Python script fails to correctly handle renamed or copied files, which can corrupt destination paths.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces two new utility scripts: tools/firebase_checks.py, which identifies modified subprojects and executes relevant Gradle tasks (such as formatting and API generation), and tools/setup_hooks.sh, which installs a Git pre-commit hook to run these checks automatically. The feedback suggests using a quoted heredoc in the setup script to prevent hardcoding absolute paths, checking for the existence of subproject directories in the Python script to handle deleted or renamed directories gracefully, and dynamically resolving the Gradle wrapper executable to ensure cross-platform compatibility on Windows.
1 participant
Introduced
firebase_checks.pyto automatically run Gradle tasks (sAppandgenerateApiTxtFile) for modified subprojects, excluding test applications and resource-only changes. Addedsetup_hooks.shto install a Git pre-commit hook that enforces these checks and aborts commits if they result in uncommitted file changes.