[Infra] Upgrade Gradle plugin dependencies and modernize codebase#8422
[Infra] Upgrade Gradle plugin dependencies and modernize codebase#8422rlazo wants to merge 2 commits into
Conversation
- Bump Firebase Performance plugin to 2.0.2 and Kotlin Gradle plugin to 2.0.21. - Replace deprecated `jcenter()` repository references with `mavenCentral()` in tests. - Update internal Kotlin code to use `uppercase()` instead of `toUpperCase()`. - Refactor type safety for attributes and properties by adding `: Any` bounds. - Update Android API references and testing configurations for compatibility.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
plugins test results69 tests 69 ✅ 1m 30s ⏱️ Results for commit 0bf6ed9. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Code Review
This pull request updates several build configurations and dependencies, including upgrading the Kotlin Gradle plugin to 2.0.21, replacing deprecated jcenter() repositories with mavenCentral(), and updating compileSdkVersion to 34 in tests. It also migrates deprecated .toUpperCase() calls to .uppercase() and refines generic type constraints in Gradle extension functions. Feedback is provided regarding a compilation error in BaseFirebaseLibraryPlugin.kt, where accessing 'it.path' on a ProjectDependency is invalid and should be reverted to 'it.dependencyProject.path'.
…irebaseLibraryPlugin.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jcenter()repository references withmavenCentral()in tests.uppercase()instead oftoUpperCase().: Anybounds.