non abstract UserInfoInterface

Author: DellaBitta

auth/integration_test/src/integration_test.cc

@@ -1440,16 +1440,19 @@ TEST_F(FirebaseAuthTest, TestAuthPersistenceWithEmailSignin) {
   WaitForCompletion(
       auth_->CreateUserWithEmailAndPassword(email.c_str(), kTestPassword),
       "CreateUserWithEmailAndPassword");
+  LogError("User creation returned\n");
   EXPECT_TRUE(auth_->current_user().is_valid());
   EXPECT_FALSE(auth_->current_user().is_anonymous());
   firebase::auth::User user = auth_->current_user();
   std::string prev_provider_id = user.provider_id();
   // Save the old provider ID list so we can make sure it's the same once
   // it's loaded again.
   std::vector<std::string> prev_provider_data_ids;
+  LogError("user.provider_data().size(): %d\n", user.provider_data().size());
   for (int i = 0; i < user.provider_data().size(); i++) {
     prev_provider_data_ids.push_back(user.provider_data()[i].provider_id());
   }
+  LogError("prev_provider_data_ids.size(): %d\n", prev_provider_data_ids.size());
   Terminate();
   ProcessEvents(2000);
   Initialize();
@@ -1460,9 +1463,11 @@ TEST_F(FirebaseAuthTest, TestAuthPersistenceWithEmailSignin) {
   EXPECT_EQ(auth_->current_user().provider_id(), prev_provider_id);
   user = auth_->current_user();
   std::vector<std::string> loaded_provider_data_ids;
+  LogError("user.provider_data().size(): %d\n", user.provider_data().size());
   for (int i = 0; i < user.provider_data().size(); i++) {
     loaded_provider_data_ids.push_back(user.provider_data()[i].provider_id());
   }
+  LogError("loaded_provider_data_ids.size(): %d\n", loaded_provider_data_ids.size());
   EXPECT_TRUE(loaded_provider_data_ids == prev_provider_data_ids);
 
   // Cleanup, ensure we are signed in as the user so we can delete it.

auth/src/desktop/user_desktop.cc

@@ -1195,11 +1195,16 @@ Future<SignInResult> User::ReauthenticateWithProvider_DEPRECATED(
 }
 
 std::vector<UserInfoInterface> User::provider_data() const {
+  printf("DEDB provider_data\n");
   std::vector<UserInfoInterface> provider_data;
   if (is_valid()) {
+    printf("DEDB is_valid\n");
     std::vector<UserInfoInterface*> deprecated_provider_data =
         provider_data_DEPRECATED();
+    printf("DEDB deprecated_provider_data size: %d\n", deprecated_provider_data.size());
+    provider_data.reserve(deprecated_provider_data.size());
     for (size_t i = 0; i < deprecated_provider_data.size(); ++i) {
+      printf("DEDB copying provider_data\n");
       UserInfoImpl user_info_impl;
       user_info_impl.uid = deprecated_provider_data[i]->uid();
       user_info_impl.email = deprecated_provider_data[i]->email();
@@ -1210,6 +1215,7 @@ std::vector<UserInfoInterface> User::provider_data() const {
       provider_data[i] = UserInfoInterfaceImpl(user_info_impl);
     }
   }
+  printf("DEDB provider_data return length: %d\n", provider_data.size());
   return provider_data;
 }
 

auth/src/include/firebase/auth/user.h

@@ -62,7 +62,7 @@ class UserInfoInterface {
   /// </csproperty>
   /// @endxmlonly
   /// </SWIG>
-  virtual std::string uid() const = 0;
+  virtual std::string uid() const { return std::string(); }
 
   /// Gets email associated with the user, if any.
   /// <SWIG>
@@ -72,7 +72,7 @@ class UserInfoInterface {
   /// </csproperty>
   /// @endxmlonly
   /// </SWIG>
-  virtual std::string email() const = 0;
+  virtual std::string email() const { return std::string(); }
 
   /// Gets the display name associated with the user, if any.
   /// <SWIG>
@@ -82,7 +82,7 @@ class UserInfoInterface {
   /// </csproperty>
   /// @endxmlonly
   /// </SWIG>
-  virtual std::string display_name() const = 0;
+  virtual std::string display_name() const { return std::string(); }
 
   /// Gets the photo url associated with the user, if any.
   /// <SWIG>
@@ -92,7 +92,7 @@ class UserInfoInterface {
   /// </csproperty>
   /// @endxmlonly
   /// </SWIG>
-  virtual std::string photo_url() const = 0;
+  virtual std::string photo_url() const { return std::string(); }
 
   /// Gets the provider ID for the user (For example, "Facebook").
   /// <SWIG>
@@ -102,10 +102,10 @@ class UserInfoInterface {
   /// </csproperty>
   /// @endxmlonly
   /// </SWIG>
-  virtual std::string provider_id() const = 0;
+  virtual std::string provider_id() const { return std::string(); }
 
   /// Gets the phone number for the user, in E.164 format.
-  virtual std::string phone_number() const = 0;
+  virtual std::string phone_number() const { return std::string(); }
 };
 
 /// @brief Additional user data returned from an identity provider.