Skip to content

Commit 3416930

Browse files
committed
Fix builder naming
1 parent 0a63d01 commit 3416930

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

functions/src/android/functions_android.cc

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -220,17 +220,16 @@ HttpsCallableReferenceInternal* FunctionsInternal::GetHttpsCallable(
220220
JNIEnv* env = app_->GetJNIEnv();
221221

222222
// Create HttpsCallableOptions
223-
jobject builder =
223+
jobject empty_builder =
224224
env->NewObject(callable_options_builder::GetClass(),
225225
callable_options_builder::GetMethodId(
226226
callable_options_builder::kBuilderConstructor));
227-
jobject builder2 = env->CallObjectMethod(
228-
builder,
227+
jobject builder = env->CallObjectMethod(
228+
empty_builder,
229229
callable_options_builder::GetMethodId(
230230
callable_options_builder::kSetLimitedUseAppCheckTokens),
231231
options.limited_use_app_check_token);
232-
env->DeleteLocalRef(builder);
233-
builder = builder2;
232+
env->DeleteLocalRef(empty_builder);
234233
jobject java_options = env->CallObjectMethod(
235234
builder,
236235
callable_options_builder::GetMethodId(callable_options_builder::kBuild));
@@ -268,17 +267,16 @@ HttpsCallableReferenceInternal* FunctionsInternal::GetHttpsCallableFromURL(
268267
JNIEnv* env = app_->GetJNIEnv();
269268

270269
// Create HttpsCallableOptions
271-
jobject builder =
270+
jobject empty_builder =
272271
env->NewObject(callable_options_builder::GetClass(),
273272
callable_options_builder::GetMethodId(
274273
callable_options_builder::kBuilderConstructor));
275-
jobject builder2 = env->CallObjectMethod(
276-
builder,
274+
jobject builder = env->CallObjectMethod(
275+
empty_builder,
277276
callable_options_builder::GetMethodId(
278277
callable_options_builder::kSetLimitedUseAppCheckTokens),
279278
options.limited_use_app_check_token);
280-
env->DeleteLocalRef(builder);
281-
builder = builder2;
279+
env->DeleteLocalRef(empty_builder);
282280
jobject java_options = env->CallObjectMethod(
283281
builder,
284282
callable_options_builder::GetMethodId(callable_options_builder::kBuild));

0 commit comments

Comments
 (0)