Cleanup

Author: AustinBenoit

analytics/src/analytics_ios.mm

@@ -246,18 +246,19 @@ void LogEvent(const char* name) {
     return Future<void>(api, future_handle.get());
   }
 
-  [AppleTransactionVerifier verifyWithTransactionId:SafeString(transaction_id) 
-                                       completion:^(BOOL isFound) {
-    MutexLock lock(g_mutex);
-    if (!internal::IsInitialized()) return;
-
-    auto* api = internal::FutureData::Get()->api();
-    if (isFound) {
-      api->Complete(future_handle, 0, "");
-    } else {
-      api->Complete(future_handle, -1, "StoreKit 2 transaction not found.");
-    }
-  }];
+  [AppleTransactionVerifier
+      verifyWithTransactionId:SafeString(transaction_id)
+                   completion:^(BOOL isFound) {
+                     MutexLock lock(g_mutex);
+                     if (!internal::IsInitialized()) return;
+
+                     auto* api = internal::FutureData::Get()->api();
+                     if (isFound) {
+                       api->Complete(future_handle, 0, "");
+                     } else {
+                       api->Complete(future_handle, -1, "StoreKit 2 transaction not found.");
+                     }
+                   }];
 
   return Future<void>(api, future_handle.get());
 }

scripts/gha/integration_testing/xcode_tool.rb

@@ -163,9 +163,6 @@ def add_custom_framework(framework_path)
   local_framework_path = "Frameworks/#{framework_name}"
   # Add the lib file as a reference
   libRef = @project['Frameworks'].new_file(framework_path)
-  if framework_name.end_with?('.xcframework')
-    libRef.last_known_file_type = 'wrapper.xcframework'
-  end
   # Add it to the build phase
   @target.frameworks_build_phase.add_file_reference(libRef)
   puts 'Finished adding framework.'

testing/sample_framework/src/app_framework.cc

@@ -33,7 +33,8 @@
 // crashing when they are missing from the system libraries on older OSs.
 namespace std {
 inline namespace __1 {
-__attribute__((weak)) void __libcpp_verbose_abort(const char* format, ...) noexcept {
+__attribute__((weak)) void __libcpp_verbose_abort(const char* format,
+                                                  ...) noexcept {
   va_list list;
   va_start(list, format);
   vfprintf(stderr, format, list);