Skip to content

Commit a28aa34

Browse files
committed
Make the github action only care about the hour
1 parent bd4a20a commit a28aa34

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

scripts/gha/report_build_status.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@
129129

130130
general_test_hour = 9
131131
firestore_test_hour = 10
132-
test_time_minute_range = 59
133132

134133
def rename_key(old_dict,old_name,new_name):
135134
"""Rename a key in a dictionary, preserving the order."""
@@ -388,9 +387,9 @@ def main(argv):
388387
if run['day'] < start_date or run['day'] > end_date: continue
389388
run['duration'] = dateutil.parser.parse(run['updated_at'], ignoretz=True) - run['date']
390389
compare_test_hour = firestore_test_hour if FLAGS.firestore else general_test_hour
391-
# The general test should start at 9:00, and firestore at 10:00, but we give it a range
392-
# because the tests can take a few minutes before starting.
393-
if run['date'].hour == compare_test_hour and run['date'].minute <= test_time_minute_range:
390+
# The scheduled time is at the top of the hour (e.g. 09:00 or 10:00).
391+
# We allow for some delay in GitHub Actions starting the job, as long as it starts in the same hour.
392+
if run['date'].hour == compare_test_hour:
394393
source_tests[day] = run
395394
all_days.add(day)
396395

0 commit comments

Comments
 (0)