Skip to content

Commit a789e0e

Browse files
morganchen12morganchen12
committed
remove uses of deprecated action
1 parent f3aa324 commit a789e0e

5 files changed

Lines changed: 37 additions & 21 deletions

File tree

‎.github/workflows/cpp-packaging.yml‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -884,11 +884,13 @@ jobs:
884884
#
885885
# This method is preferred over the "personal access token" solution, as the GitHub App's scope is limited to just
886886
# the firebase-cpp-sdk repository.
887-
uses: tibdex/github-app-token@32691ba7c9e7063bd457bd8f2a5703138591fa58 # ratchet:tibdex/github-app-token@v1
887+
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
888888
id: generate-token
889889
with:
890-
app_id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
891-
private_key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
890+
# we should migrate to client-id
891+
app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
892+
private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
893+
permission-actions: write
892894
- name: Use GitHub API to start workflow
893895
shell: bash
894896
run: |
@@ -951,11 +953,13 @@ jobs:
951953
run: pip install -r scripts/gha/python_requirements.txt
952954
# The default token can't run workflows, so get an alternate token.
953955
- name: Generate token for GitHub API
954-
uses: tibdex/github-app-token@32691ba7c9e7063bd457bd8f2a5703138591fa58 # ratchet:tibdex/github-app-token@v1
956+
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
955957
id: generate-token
956958
with:
957-
app_id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
958-
private_key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
959+
# we should migrate to client-id
960+
app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
961+
private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
962+
permission-actions: write
959963
- name: Retry failed tests
960964
run: |
961965
echo "::warning ::Attempting to retry failed jobs"

‎.github/workflows/integration_tests.yml‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1523,11 +1523,13 @@ jobs:
15231523
# Use a different token to remove the "in-progress" label,
15241524
# to allow the removal to trigger the "Check Labels" workflow.
15251525
- name: Generate token for GitHub API
1526-
uses: tibdex/github-app-token@32691ba7c9e7063bd457bd8f2a5703138591fa58 # ratchet:tibdex/github-app-token@v1
1526+
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
15271527
id: generate-token
15281528
with:
1529-
app_id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
1530-
private_key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
1529+
# we should migrate to client-id
1530+
app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
1531+
private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
1532+
permission-pull-requests: write
15311533
- name: Update PR label and comment
15321534
if: ${{ needs.check_and_prepare.outputs.pr_number }}
15331535
shell: bash
@@ -1596,11 +1598,13 @@ jobs:
15961598
run: pip install -r scripts/gha/python_requirements.txt
15971599
# The default token can't run workflows, so get an alternate token.
15981600
- name: Generate token for GitHub API
1599-
uses: tibdex/github-app-token@32691ba7c9e7063bd457bd8f2a5703138591fa58 # ratchet:tibdex/github-app-token@v1
1601+
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
16001602
id: generate-token
16011603
with:
1602-
app_id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
1603-
private_key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
1604+
# we should migrate to client-id
1605+
app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
1606+
private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
1607+
permission-actions: write
16041608
- name: Retry failed tests
16051609
run: |
16061610
echo "::warning ::Attempting to retry failed tests"

‎.github/workflows/retry-test-failures.yml‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@ jobs:
1313
runs-on: ubuntu-22.04
1414
steps:
1515
- name: Get token for firebase-workflow-trigger
16-
uses: tibdex/github-app-token@32691ba7c9e7063bd457bd8f2a5703138591fa58 # ratchet:tibdex/github-app-token@v1
16+
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
1717
id: generate-token
1818
with:
19-
app_id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
20-
private_key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
19+
# we should migrate to client-id
20+
app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
21+
private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
22+
permission-actions: write
2123

2224
- name: Setup python
2325
uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4

‎.github/workflows/update-dependencies.yml‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,14 @@ jobs:
3030
runs-on: macos-15
3131
steps:
3232
- name: Get token for firebase-workflow-trigger
33-
uses: tibdex/github-app-token@32691ba7c9e7063bd457bd8f2a5703138591fa58 # ratchet:tibdex/github-app-token@v1
33+
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
3434
id: generate-token
3535
with:
36-
app_id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
37-
private_key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
36+
# we should migrate to client-id
37+
app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
38+
private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
39+
permission-contents: write
40+
permission-pull-requests: write
3841

3942
- name: Setup python
4043
uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4

‎.github/workflows/update-feature-branches.yml‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,14 @@ jobs:
7474
branch_name: ${{ fromJson(needs.list_feature_branches.outputs.branch_list) }}
7575
steps:
7676
- name: Get token for firebase-workflow-trigger
77-
uses: tibdex/github-app-token@32691ba7c9e7063bd457bd8f2a5703138591fa58 # ratchet:tibdex/github-app-token@v1
77+
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
7878
id: generate-token
7979
with:
80-
app_id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
81-
private_key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
80+
# we should migrate to client-id
81+
app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
82+
private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
83+
permission-contents: write
84+
permission-pull-requests: write
8285

8386
- name: Setup python
8487
uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4

0 commit comments

Comments
 (0)